Fix comment about LoadBloomsOnOpen#1478
Merged
jarifibrahim merged 2 commits intomasterfrom Aug 26, 2020
Merged
Conversation
NamanJain8
approved these changes
Aug 26, 2020
Contributor
NamanJain8
left a comment
There was a problem hiding this comment.
The comment needs to be fixed at WithLoadBloomsOnOpen() too
Contributor
Author
|
@NamanJain8 Fixed it. |
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 26, 2020
The comment about LoadBloomsOnOpen was incorrect. This PR fixes it. (cherry picked from commit 431aee1)
jarifibrahim
pushed a commit
that referenced
this pull request
Aug 26, 2020
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
The comment about LoadBloomsOnOpen was incorrect. This PR fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment about LoadBloomsOnOpen was incorrect. This PR fixes it.
This change is