Elections module and election administration#6065
Merged
microstudi merged 21 commits intodevelopfrom May 25, 2020
Merged
Conversation
401dcae to
5e3a587
Compare
Contributor
Author
|
@decidim/product this PR is ready to be tested in staging! |
52fb402 to
395b60f
Compare
Member
|
Thanks @leio10! I have some doubts about the notifications. I see that 2 types of notifications are generated: one when the "Elections" component is published, and another for each new Election that is created within the component. I think we don't want this second notification, because every time you create a new Election, you still have to configure the questions for that Election. IMO it makes more sense to notify that a new Election (within the Election component) is active when you have already set up the questions that form it, but I don't want to anticipate and maybe we should discuss that with the issue #5960? |
Contributor
Author
|
ok @carolromero! I'll just remove it and leave the discussion for later 👍 |
37dfc11 to
f09fc7a
Compare
mrcasals
previously approved these changes
May 6, 2020
Contributor
mrcasals
left a comment
There was a problem hiding this comment.
Nice job!! Looks good to me!
agustibr
suggested changes
May 6, 2020
Contributor
agustibr
left a comment
There was a problem hiding this comment.
👍 Good to go! only one comment in the README
Contributor
Author
|
@decidim/core this was approved by product and ready to be reviewed |
agustibr
previously approved these changes
May 6, 2020
|
|
||
| ```ruby | ||
| gem 'decidim-<%= component_name %> | ||
| gem "decidim-<%= component_name %>" |
c472f75 to
50732fa
Compare
245006f to
cb1cc79
Compare
fix: add missing timestamps fields for elections
Only admins can manage them. Elections can't be deleted after they start.
cb1cc79 to
5ce7e50
Compare
microstudi
previously approved these changes
May 25, 2020
microstudi
approved these changes
May 25, 2020
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
May 27, 2020
* develop: Include year in meetings card (decidim#6102) Add attachment enabled option to initiative types and initiatives (decidim#6036) Fix a flaky test in group profile conversations (decidim#6123) Add attachments to Initiatives (decidim#5844) Add initiatives export (decidim#6070) Improvements to conversations with more than one participant (decidim#6094) Elections module and election administration (decidim#6065) Separate forms in steps (decidim#6108) Add sorting by publishing date to initiatives (decidim#6016) Improve proposal preview: Use proposal card when previewing a proposal draft (decidim#6064) Newsletter templates fixes (decidim#6096) # Conflicts: # decidim-initiatives/app/models/decidim/initiative.rb # decidim-initiatives/spec/system/admin/initiative_types_controller_spec.rb
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
May 28, 2020
* feature/add_areas_to_initiatives: (30 commits) Adds areas to FO filters Fix lint issue Fixes rubocop issues Updates changelog Adds areas to initiatives Send notification when signature threshold reached (decidim#6098) Adds filter by initiative type to admin panel (decidim#6093) Require confirmation on exiting a survey mid-answering (decidim#6118) Information message when there isn't any Proposal (decidim#6063) Set email asset host dynamically (decidim#5888) Harmonizes the design of initiatives search in FO (decidim#6090) Include year in meetings card (decidim#6102) Add attachment enabled option to initiative types and initiatives (decidim#6036) Fix a flaky test in group profile conversations (decidim#6123) Add attachments to Initiatives (decidim#5844) Add initiatives export (decidim#6070) Improvements to conversations with more than one participant (decidim#6094) Elections module and election administration (decidim#6065) Separate forms in steps (decidim#6108) Add sorting by publishing date to initiatives (decidim#6016) ... # Conflicts: # decidim-initiatives/app/cells/decidim/initiatives/initiative_m_cell.rb # decidim-initiatives/app/commands/decidim/initiatives/admin/update_initiative.rb # decidim-initiatives/app/controllers/decidim/initiatives/initiatives_controller.rb # decidim-initiatives/app/forms/decidim/initiatives/admin/initiative_form.rb # decidim-initiatives/app/helpers/decidim/initiatives/application_helper.rb # decidim-initiatives/app/models/decidim/initiative.rb # decidim-initiatives/app/services/decidim/initiatives/initiative_search.rb # decidim-initiatives/app/views/decidim/initiatives/create_initiative/fill_data.html.erb # decidim-initiatives/app/views/decidim/initiatives/initiatives/_filters.html.erb # decidim-initiatives/app/views/decidim/initiatives/initiatives/_tags.html.erb # decidim-initiatives/config/locales/en.yml # decidim-initiatives/db/migrate/20200514085422_add_area_to_initiatives.rb # decidim-initiatives/db/migrate/20200514102631_add_area_enabled_option_to_initiatives.rb # decidim-initiatives/spec/forms/initiative_form_spec.rb # decidim-initiatives/spec/services/decidim/initiatives/initiative_search_spec.rb # decidim-initiatives/spec/shared/update_initiative_type_example.rb # decidim-initiatives/spec/system/admin/admin_manages_initiatives_spec.rb # decidim-initiatives/spec/system/admin/initiative_types_controller_spec.rb # decidim-initiatives/spec/system/filter_initiatives_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Adds the new elections module and implements the admin zone for the election model.
The implementation includes some features that are common for all modules:
public-only,admin-onlyorall, whereallis used for actions like component publishing, meeting creation or debates creations).Election creation event: all the users following the participatory space that contains the election module will be notified about a new election creation.Also, for security reasons, deletion of started elections (finished or not) is not allowed.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)