Set email asset host dynamically#5888
Set email asset host dynamically#5888jesusdb merged 8 commits intodecidim:developfrom armandfardeau:feature/set-email-asset-host
Conversation
|
Hello @armandfardeau, has this been approved by @decidim/product? |
|
@carolromero this is ready to be reviewed :) |
Not yet ! |
decidim-core/app/mailers/concerns/decidim/multitenant_asset_host.rb
Outdated
Show resolved
Hide resolved
tramuntanal
left a comment
There was a problem hiding this comment.
Good contribution @armandfardeau I just have a question and share the same with @microstudi
decidim-core/app/mailers/concerns/decidim/multitenant_asset_host.rb
Outdated
Show resolved
Hide resolved
decidim-core/app/mailers/concerns/decidim/multitenant_asset_host.rb
Outdated
Show resolved
Hide resolved
|
Hi @decidim/product , can you please confirm this PR? I find it interesting |
|
@tramuntanal I don't understand the purpose of this feature. Could you give an example of what solves this? Thanks! |
When you receive and email from a tenant instead of the main Decidim platform, any image or asset linked in the email will show the URL of the main instance instead of the tenant. Most people won't notice it, but it is healthy to be consistent. |
|
thanks for the explanation @microstudi, all clear now, and thanks for the contribution @armandfardeau |
|
@armandfardeau it's approved, can you apply changes from reviews and we're done please? |
decidim-core/app/mailers/concerns/decidim/multitenant_asset_host.rb
Outdated
Show resolved
Hide resolved
jesusdb
left a comment
There was a problem hiding this comment.
Thanks for the contribution! 😄
|
Hi! After merging this PR, |
|
I'm sorry, I could swear I saw all tests passing. I just re-run the test, if it fails, I will revert it |
|
Maybe the tests passed, but got a weird error after #6096 and the branch in this PR was not updated, so it was not detected? 🤔 |
* feature/add_areas_to_initiatives: (30 commits) Adds areas to FO filters Fix lint issue Fixes rubocop issues Updates changelog Adds areas to initiatives Send notification when signature threshold reached (decidim#6098) Adds filter by initiative type to admin panel (decidim#6093) Require confirmation on exiting a survey mid-answering (decidim#6118) Information message when there isn't any Proposal (decidim#6063) Set email asset host dynamically (decidim#5888) Harmonizes the design of initiatives search in FO (decidim#6090) Include year in meetings card (decidim#6102) Add attachment enabled option to initiative types and initiatives (decidim#6036) Fix a flaky test in group profile conversations (decidim#6123) Add attachments to Initiatives (decidim#5844) Add initiatives export (decidim#6070) Improvements to conversations with more than one participant (decidim#6094) Elections module and election administration (decidim#6065) Separate forms in steps (decidim#6108) Add sorting by publishing date to initiatives (decidim#6016) ... # Conflicts: # decidim-initiatives/app/cells/decidim/initiatives/initiative_m_cell.rb # decidim-initiatives/app/commands/decidim/initiatives/admin/update_initiative.rb # decidim-initiatives/app/controllers/decidim/initiatives/initiatives_controller.rb # decidim-initiatives/app/forms/decidim/initiatives/admin/initiative_form.rb # decidim-initiatives/app/helpers/decidim/initiatives/application_helper.rb # decidim-initiatives/app/models/decidim/initiative.rb # decidim-initiatives/app/services/decidim/initiatives/initiative_search.rb # decidim-initiatives/app/views/decidim/initiatives/create_initiative/fill_data.html.erb # decidim-initiatives/app/views/decidim/initiatives/initiatives/_filters.html.erb # decidim-initiatives/app/views/decidim/initiatives/initiatives/_tags.html.erb # decidim-initiatives/config/locales/en.yml # decidim-initiatives/db/migrate/20200514085422_add_area_to_initiatives.rb # decidim-initiatives/db/migrate/20200514102631_add_area_enabled_option_to_initiatives.rb # decidim-initiatives/spec/forms/initiative_form_spec.rb # decidim-initiatives/spec/services/decidim/initiatives/initiative_search_spec.rb # decidim-initiatives/spec/shared/update_initiative_type_example.rb # decidim-initiatives/spec/system/admin/admin_manages_initiatives_spec.rb # decidim-initiatives/spec/system/admin/initiative_types_controller_spec.rb # decidim-initiatives/spec/system/filter_initiatives_spec.rb
* develop: Send notification when signature threshold reached (decidim#6098) Adds filter by initiative type to admin panel (decidim#6093) Require confirmation on exiting a survey mid-answering (decidim#6118) Information message when there isn't any Proposal (decidim#6063) Set email asset host dynamically (decidim#5888) Harmonizes the design of initiatives search in FO (decidim#6090)
* Set email asset host dynamically * Add changelog entry * Use decidim force_ssl configuration accessor * Fix typo
🎩 What? Why?
Set emails asset host dynamically.
It can be strange for users to find resource URLs that are linked to another organization, this development allows to either define a common asset host for all organizations (example: assets.decidim.org) or to reroute assets according to the organization's host.
📋 Subtasks
CHANGELOGentry