Send notification when signature threshold reached by armandfardeau · Pull Request #6098 · decidim/decidim

armandfardeau · 2020-05-14T19:28:10Z

🎩 What? Why?

This PR will add a notification that will be sent authors, promoting committee members, followers of the initiative and admins to receive a notification when an initiative reaches the support threshold.

linked to : https://meta.decidim.org/processes/roadmap/f/122/proposals/15280

📋 Subtasks

Add CHANGELOG entry
Add tests

virgile-dev · 2020-05-15T17:04:40Z

@armandfardeau looks like we didn't understand each other on this one.
It's the admin who click on the button to accept an initiative so it doesn't make sense to send him and email when accepting an initiative. Same for rejecting.

It does for authors, followers, promotting committee members though. So maybe we can slightly revamp this to exclude admin and include authors, followers, promotting committee members.

What I wanted to do with this PR is to send a notification to the admin when the initiative reaches the 100% milestone. (see this PR for ref)

virgile-dev · 2020-05-19T08:24:13Z

CHANGELOG.md


 ### Added

+- **decidim-initiatives**: Notify admin when an initiative is accepted. [\#6098](https://github.com/decidim/decidim/pull/6098)


Notify authors, promoting committee members, followers of the initiative and admins to receive a notification when an initiative reaches the 100% of the support threshold.

virgile-dev · 2020-05-21T08:59:35Z

@carolromero is this one okay with you ? I see that @andreslucena had a look.

decidim-initiatives/app/commands/decidim/initiatives/vote_initiative.rb

andreslucena · 2020-05-22T08:34:09Z

@carolromero is this one okay with you ? I see that @andreslucena had a look

Hey all, I've actually didn't look at this, it's just that I hate long titles on PR/commits. I've updated the docs with this a few weeks ago, please take a look at https://github.com/decidim/decidim/blob/develop/docs/development_guide.md#git-commit-messages-and-pull-request-titles

The title "Notify authors, promoting committee members, followers of the initiative and admins to receive a notification when an initiative reaches the 100% of the support threshold" is 171 characters
Hell, even the new title is too long by the guidelines that I've linked (we're on 71 chars, guidelines says 50 chars), but I can live with that for the time being.

(Still the title is shorter than the title of Garcia Marquez book "Relatos de un naufrago" / "The Story of a Shipwrecked Sailor" which full title is "The Story of a Shipwrecked Sailor: Who Drifted on a Liferaft for Ten Days Without Food or Water, Was Proclaimed a National Hero, Kissed by Beauty Queens, Made Rich Through Publicity, and Then Spurned by the Government and Forgotten for All Time.", 246 chars!!)

armandfardeau · 2020-05-22T08:44:18Z

@carolromero is this one okay with you ? I see that @andreslucena had a look

Hey all, I've actually didn't look at this, it's just that I hate long titles on PR/commits. I've updated the docs with this a few weeks ago, please take a look at https://github.com/decidim/decidim/blob/develop/docs/development_guide.md#git-commit-messages-and-pull-request-titles

The title "Notify authors, promoting committee members, followers of the initiative and admins to receive a notification when an initiative reaches the 100% of the support threshold" is 171 characters
Hell, even the new title is too long by the guidelines that I've linked (we're on 71 chars, guidelines says 50 chars), but I can live with that for the time being.

(Still the title is shorter than the title of Garcia Marquez book "Relatos de un naufrago" / "The Story of a Shipwrecked Sailor" which full title is "The Story of a Shipwrecked Sailor: Who Drifted on a Liferaft for Ten Days Without Food or Water, Was Proclaimed a National Hero, Kissed by Beauty Queens, Made Rich Through Publicity, and Then Spurned by the Government and Forgotten for All Time.", 246 chars!!)

I was not aware of these new guidelines, thank you for the clarification. I've updated this P.R., let me know if anything is still out of order.

virgile-dev · 2020-05-22T14:29:51Z

@carolromero thanks for accepting the proposal on meta decidim. Does this mean that @Leusev can merge the PR ?

carolromero · 2020-05-22T14:46:47Z

@virgile-dev yep, it's ok on my side

armandfardeau · 2020-05-25T14:19:27Z

@Leusev GH actions had a malfunction, can you restart them on your side? Everything should be green by now

Leusev · 2020-05-25T15:03:41Z

Hi @armandfardeau
for sure, I've re-launched "[CI] admin / Tests" again
I know it is repetitive, but it seems that the changelog has conflict again
Thanks!

armandfardeau · 2020-05-25T18:15:27Z

Hi @armandfardeau
for sure, I've re-launched "[CI] admin / Tests" again
I know it is repetitive, but it seems that the changelog has conflict again
Thanks!

I should have done my chores a long time ago ;)

virgile-dev · 2020-05-26T07:03:11Z

@Leusev could you check if we can merge this now ? Thanks !

Leusev

All ok now @armandfardeau 👍

* feature/add_areas_to_initiatives: (30 commits) Adds areas to FO filters Fix lint issue Fixes rubocop issues Updates changelog Adds areas to initiatives Send notification when signature threshold reached (decidim#6098) Adds filter by initiative type to admin panel (decidim#6093) Require confirmation on exiting a survey mid-answering (decidim#6118) Information message when there isn't any Proposal (decidim#6063) Set email asset host dynamically (decidim#5888) Harmonizes the design of initiatives search in FO (decidim#6090) Include year in meetings card (decidim#6102) Add attachment enabled option to initiative types and initiatives (decidim#6036) Fix a flaky test in group profile conversations (decidim#6123) Add attachments to Initiatives (decidim#5844) Add initiatives export (decidim#6070) Improvements to conversations with more than one participant (decidim#6094) Elections module and election administration (decidim#6065) Separate forms in steps (decidim#6108) Add sorting by publishing date to initiatives (decidim#6016) ... # Conflicts: # decidim-initiatives/app/cells/decidim/initiatives/initiative_m_cell.rb # decidim-initiatives/app/commands/decidim/initiatives/admin/update_initiative.rb # decidim-initiatives/app/controllers/decidim/initiatives/initiatives_controller.rb # decidim-initiatives/app/forms/decidim/initiatives/admin/initiative_form.rb # decidim-initiatives/app/helpers/decidim/initiatives/application_helper.rb # decidim-initiatives/app/models/decidim/initiative.rb # decidim-initiatives/app/services/decidim/initiatives/initiative_search.rb # decidim-initiatives/app/views/decidim/initiatives/create_initiative/fill_data.html.erb # decidim-initiatives/app/views/decidim/initiatives/initiatives/_filters.html.erb # decidim-initiatives/app/views/decidim/initiatives/initiatives/_tags.html.erb # decidim-initiatives/config/locales/en.yml # decidim-initiatives/db/migrate/20200514085422_add_area_to_initiatives.rb # decidim-initiatives/db/migrate/20200514102631_add_area_enabled_option_to_initiatives.rb # decidim-initiatives/spec/forms/initiative_form_spec.rb # decidim-initiatives/spec/services/decidim/initiatives/initiative_search_spec.rb # decidim-initiatives/spec/shared/update_initiative_type_example.rb # decidim-initiatives/spec/system/admin/admin_manages_initiatives_spec.rb # decidim-initiatives/spec/system/admin/initiative_types_controller_spec.rb # decidim-initiatives/spec/system/filter_initiatives_spec.rb

* develop: Send notification when signature threshold reached (decidim#6098) Adds filter by initiative type to admin panel (decidim#6093) Require confirmation on exiting a survey mid-answering (decidim#6118) Information message when there isn't any Proposal (decidim#6063) Set email asset host dynamically (decidim#5888) Harmonizes the design of initiatives search in FO (decidim#6090)

* Notify admin when initiative is accepted * Don't send notificaiton to admin if initiative is rejected * Revert c3212c0 * Notify admin if the percentage is 100% * Normalize en locale * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Ramon Costa <ramon.costa@gmail.com>

Notify admin when initiative is accepted

c3212c0

armandfardeau changed the title ~~Notify admin when initiative is accepted~~ Send notification when initiative reaches 100% of support thereshold May 15, 2020

Don't send notificaiton to admin if initiative is rejected

e2f9e97

armandfardeau added 3 commits May 18, 2020 10:29

Revert c3212c0

f545aab

Notify admin if the percentage is 100%

dc77337

Normalize en locale

417c1e3

virgile-dev reviewed May 19, 2020

View reviewed changes

Update CHANGELOG.md

ed881bb

armandfardeau changed the title ~~Send notification when initiative reaches 100% of support thereshold~~ Notify authors, promoting committee members, followers of the initiative and admins to receive a notification when an initiative reaches the 100% of the support threshold May 19, 2020

andreslucena changed the title ~~Notify authors, promoting committee members, followers of the initiative and admins to receive a notification when an initiative reaches the 100% of the support threshold~~ Send notification when initiative reaches 100% of signatures threshold May 20, 2020

Leusev added the in-review label May 21, 2020

Leusev self-requested a review May 21, 2020 13:56

Leusev suggested changes May 21, 2020

View reviewed changes

decidim-initiatives/app/commands/decidim/initiatives/vote_initiative.rb Show resolved Hide resolved

Update CHANGELOG.md

153c34d

armandfardeau changed the title ~~Send notification when initiative reaches 100% of signatures threshold~~ Send notification when signature threshold reached May 22, 2020

Update CHANGELOG.md

7925cbb

Merge branch 'develop' into feature/notify-admin-support-result

570512d

virgile-dev mentioned this pull request May 22, 2020

Finish PR 5500 initiative signature gauge OpenSourcePolitics/dev#36

Open

armandfardeau requested a review from Leusev May 25, 2020 14:17

Leusev self-assigned this May 25, 2020

Merge branch 'develop' into feature/notify-admin-support-result

a8ddbe2

Leusev added 2 commits May 27, 2020 15:56

Merge branch 'develop' into feature/notify-admin-support-result

5065004

Merge branch 'develop' into feature/notify-admin-support-result

4f6d034

Leusev approved these changes May 28, 2020

View reviewed changes

Leusev merged commit cf6c671 into decidim:develop May 28, 2020

armandfardeau mentioned this pull request Jul 1, 2020

Don't send notification if threshold has already been reached #6261

Merged

1 task

armandfardeau deleted the feature/notify-admin-support-result branch July 17, 2020 07:15


		### Added

		- decidim-initiatives: Notify admin when an initiative is accepted. [\#6098](https://github.com/decidim/decidim/pull/6098)

Uh oh!

Conversation

armandfardeau commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📋 Subtasks

Uh oh!

virgile-dev commented May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virgile-dev May 19, 2020

Choose a reason for hiding this comment

Uh oh!

virgile-dev commented May 21, 2020

Uh oh!

Uh oh!

andreslucena commented May 22, 2020

Uh oh!

armandfardeau commented May 22, 2020

Uh oh!

virgile-dev commented May 22, 2020

Uh oh!

carolromero commented May 22, 2020

Uh oh!

armandfardeau commented May 25, 2020

Uh oh!

Leusev commented May 25, 2020

Uh oh!

armandfardeau commented May 25, 2020

Uh oh!

virgile-dev commented May 26, 2020

Uh oh!

Leusev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

armandfardeau commented May 14, 2020 •

edited

Loading

virgile-dev commented May 15, 2020 •

edited

Loading