Information message when there isn't any Proposal#6063
Merged
microstudi merged 19 commits intodevelopfrom May 27, 2020
Merged
Conversation
added 8 commits
May 6, 2020 19:36
…e_are_not_proposals
tramuntanal
suggested changes
May 15, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
Hi @gemmatm good job!
I only have a suggestion regarding indentations.
Can you also please take a look at linter checks? and resolve CHANGELOG.mf conflicts?
…e_are_not_proposals
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
…e_are_not_proposals
Contributor
|
molt be, @gemmatm |
…e_are_not_proposals
…e_are_not_proposals
microstudi
previously approved these changes
May 26, 2020
…e_are_not_proposals
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
May 28, 2020
* feature/add_areas_to_initiatives: (30 commits) Adds areas to FO filters Fix lint issue Fixes rubocop issues Updates changelog Adds areas to initiatives Send notification when signature threshold reached (decidim#6098) Adds filter by initiative type to admin panel (decidim#6093) Require confirmation on exiting a survey mid-answering (decidim#6118) Information message when there isn't any Proposal (decidim#6063) Set email asset host dynamically (decidim#5888) Harmonizes the design of initiatives search in FO (decidim#6090) Include year in meetings card (decidim#6102) Add attachment enabled option to initiative types and initiatives (decidim#6036) Fix a flaky test in group profile conversations (decidim#6123) Add attachments to Initiatives (decidim#5844) Add initiatives export (decidim#6070) Improvements to conversations with more than one participant (decidim#6094) Elections module and election administration (decidim#6065) Separate forms in steps (decidim#6108) Add sorting by publishing date to initiatives (decidim#6016) ... # Conflicts: # decidim-initiatives/app/cells/decidim/initiatives/initiative_m_cell.rb # decidim-initiatives/app/commands/decidim/initiatives/admin/update_initiative.rb # decidim-initiatives/app/controllers/decidim/initiatives/initiatives_controller.rb # decidim-initiatives/app/forms/decidim/initiatives/admin/initiative_form.rb # decidim-initiatives/app/helpers/decidim/initiatives/application_helper.rb # decidim-initiatives/app/models/decidim/initiative.rb # decidim-initiatives/app/services/decidim/initiatives/initiative_search.rb # decidim-initiatives/app/views/decidim/initiatives/create_initiative/fill_data.html.erb # decidim-initiatives/app/views/decidim/initiatives/initiatives/_filters.html.erb # decidim-initiatives/app/views/decidim/initiatives/initiatives/_tags.html.erb # decidim-initiatives/config/locales/en.yml # decidim-initiatives/db/migrate/20200514085422_add_area_to_initiatives.rb # decidim-initiatives/db/migrate/20200514102631_add_area_enabled_option_to_initiatives.rb # decidim-initiatives/spec/forms/initiative_form_spec.rb # decidim-initiatives/spec/services/decidim/initiatives/initiative_search_spec.rb # decidim-initiatives/spec/shared/update_initiative_type_example.rb # decidim-initiatives/spec/system/admin/admin_manages_initiatives_spec.rb # decidim-initiatives/spec/system/admin/initiative_types_controller_spec.rb # decidim-initiatives/spec/system/filter_initiatives_spec.rb
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
May 29, 2020
* develop: Send notification when signature threshold reached (decidim#6098) Adds filter by initiative type to admin panel (decidim#6093) Require confirmation on exiting a survey mid-answering (decidim#6118) Information message when there isn't any Proposal (decidim#6063) Set email asset host dynamically (decidim#5888) Harmonizes the design of initiatives search in FO (decidim#6090)
anaghavl
pushed a commit
to codegram/decidim
that referenced
this pull request
Jun 3, 2020
* Add information message * Add translations * Fix translations * Update information message on the correct view * Add spec proposals index * Update spec for proposals index * Fix indentation * Update Changelog * Update decidim-proposals/spec/system/index_proposals_spec.rb Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Fix linter checks * Change information message * Update index_proposals_spec.rb * Update index_proposals_spec.rb Co-authored-by: Gemma <gemmatm@coditramuntana.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> Co-authored-by: Ivan Vergés <ivan@platoniq.net>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This feature adds an information message when there isn't any Proposal or when the filtering doesn't find any Proposal with the filtered criteria.
📌 Related Issues
📋 Subtasks
CHANGELOGentry