Improve proposal preview: Use proposal card when previewing a proposal draft#6064
Merged
jesusdb merged 8 commits intodecidim:developfrom May 25, 2020
Merged
Conversation
1 task
Contributor
|
Hi @verarojman, could you check the "Lint / Lint code" failing test? And the conflicting file, please :) |
Contributor
|
Hi @verarojman, has this been approved by @decidim/product? I see the comment from approval is by @carolromero in #5923? Could you please check the conflicting file? Other than that, it looks good to me! |
Contributor
Author
|
I think it is approved by @decidim/product since they are the ones that suggested the task. I updated the changelog, should be good to go now :) |
Member
|
@jesusdb yes this has been reviewed and it's working ok! |
ace
pushed a commit
to aspgems/decidim
that referenced
this pull request
May 27, 2020
* develop: Include year in meetings card (decidim#6102) Add attachment enabled option to initiative types and initiatives (decidim#6036) Fix a flaky test in group profile conversations (decidim#6123) Add attachments to Initiatives (decidim#5844) Add initiatives export (decidim#6070) Improvements to conversations with more than one participant (decidim#6094) Elections module and election administration (decidim#6065) Separate forms in steps (decidim#6108) Add sorting by publishing date to initiatives (decidim#6016) Improve proposal preview: Use proposal card when previewing a proposal draft (decidim#6064) Newsletter templates fixes (decidim#6096) # Conflicts: # decidim-initiatives/app/models/decidim/initiative.rb # decidim-initiatives/spec/system/admin/initiative_types_controller_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR makes proposal draft previews use the card layout. Also, when images are enabled, the preview shows the final presentation of the image in the card.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots
Proposal preview with main image
Proposal preview from individual author
Preview of co-authored proposal