Update DownloadYourData exports for decidim-initiatives#13961
Merged
Update DownloadYourData exports for decidim-initiatives#13961
decidim-initiatives#13961Conversation
22 tasks
alecslupu
suggested changes
Jan 28, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I have tried it, and there is no export generated. Apparenty, you've forgot to add
participatory_space.data_portable_entities = [
"Decidim::Initiative"
]
to decidim-initiatives/lib/decidim/initiatives/participatory_space.rb
Member
Author
Good one! I fixed it on bfde8f6 I added a spec just in case, and also for checking out the missing i18n keys here Finally, I also fixed a bug like the one you mentioned in #13958 (review) This is ready for another round
|
alecslupu
reviewed
Jan 29, 2025
decidim-initiatives/spec/serializers/download_your_data_initiative_serializer_spec.rb
Outdated
Show resolved
Hide resolved
alecslupu
previously requested changes
Jan 29, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
The specs are failing Could you have a look on my suggestion? ...
alecslupu
approved these changes
Jan 29, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
👍
Merging with codecov failing pipeline.
entantoencuanto
added a commit
that referenced
this pull request
Jan 30, 2025
* feature/ephemeral_to_regular_users: Add integration test of ephemeral user authorization transfer Update test Make transferrable authorization when duplicate user is ephemeral Revert "Fix answer choices default order" (#13975) Fix DownloadYourData core pipeline failures (#13970) Update DownloadYourData exports for `decidim-proposals` (#13958) Update DownloadYourData exports for `decidim-initiatives` (#13961) Fix answer choices default order (#13955) Fix 'Conference media link creation form has wrong title' (#13946) Add etiquette validator to Debates and Meetings (#13274) Enable users to edit their survey answers (#13800) Fix "Missing padding-top on proposals page" (#13945)
andreslucena
added a commit
that referenced
this pull request
Mar 3, 2025
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR updates the DownloadYourData exports for decidim-initiatives models.
On this case what I'm doing is:
📌 Related Issues
Testing