Add etiquette validator to Debates and Meetings#13274
Merged
andreslucena merged 25 commits intodecidim:developfrom Jan 29, 2025
Merged
Conversation
…e/add-etiquette-validator-to-models
…-etiquette-validator-to-models
alecslupu
reviewed
Nov 16, 2024
…-etiquette-validator-to-models
Member
|
@alecslupu seems like there are some relevant failing specs here, can you check them out 🙏🏽 ? |
…m:tremend-cofe/decidim into feature/add-etiquette-validator-to-models
…-etiquette-validator-to-models
Member
andreslucena
left a comment
There was a problem hiding this comment.
Two small changes and we're ready to go
decidim-proposals/spec/forms/decidim/proposals/admin/admin_proposal_form_spec.rb
Show resolved
Hide resolved
Contributor
@andreslucena This is ready for another round |
entantoencuanto
added a commit
that referenced
this pull request
Jan 30, 2025
* feature/ephemeral_to_regular_users: Add integration test of ephemeral user authorization transfer Update test Make transferrable authorization when duplicate user is ephemeral Revert "Fix answer choices default order" (#13975) Fix DownloadYourData core pipeline failures (#13970) Update DownloadYourData exports for `decidim-proposals` (#13958) Update DownloadYourData exports for `decidim-initiatives` (#13961) Fix answer choices default order (#13955) Fix 'Conference media link creation form has wrong title' (#13946) Add etiquette validator to Debates and Meetings (#13274) Enable users to edit their survey answers (#13800) Fix "Missing padding-top on proposals page" (#13945)
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
* Attache etiquette validator to models * Implement TranslatedEtiquetteValidator * Fix lint issues, remove validator from proposal model * Fix some validator issues and lint offenses * Update proposal_form_examples.rb * Update translated_etiquette_validator.rb * Update debate_form_spec.rb * Update debate_form_spec.rb * Update and fix tests * Update user_creates_meeting_spec.rb * Update decidim-debates/app/forms/decidim/debates/debate_form.rb * Fix debate specs * Fix specs * Fix meetings * Fix validator * Fix comment on TranslatedEtiquetteValidator * Removed skip_etiquette_validation option --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Attache etiquette validator to models * Implement TranslatedEtiquetteValidator * Fix lint issues, remove validator from proposal model * Fix some validator issues and lint offenses * Update proposal_form_examples.rb * Update translated_etiquette_validator.rb * Update debate_form_spec.rb * Update debate_form_spec.rb * Update and fix tests * Update user_creates_meeting_spec.rb * Update decidim-debates/app/forms/decidim/debates/debate_form.rb * Fix debate specs * Fix specs * Fix meetings * Fix validator * Fix comment on TranslatedEtiquetteValidator * Removed skip_etiquette_validation option --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Back in #12876, in the #12876 (comment), the product and maintainers teams requested that Etiquette Validator should work for all the user generated contents: Proposals, Meetings, Debates
This PR implements that request.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you are proposing
