Skip to content

Fix 'Conference media link creation form has wrong title'#13946

Merged
andreslucena merged 2 commits intodevelopfrom
fix/conference-media-links
Jan 29, 2025
Merged

Fix 'Conference media link creation form has wrong title'#13946
andreslucena merged 2 commits intodevelopfrom
fix/conference-media-links

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This PR fixes the wrong label in the media links conference page.

📌 Related Issues

Link your PR to an issue

Testing

  1. Go to the admin panel
  2. Go to a Conference
  3. Click on "Media links"
  4. Click on "New media link"
  5. See title of the form is "New conference speaker."
  6. Apply patch
  7. See the title being changed

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added type: fix PRs that implement a fix for a bug release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 labels Jan 26, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 26, 2025
@alecslupu alecslupu marked this pull request as ready for review January 26, 2025 14:50
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena this is ready for a new round

@andreslucena andreslucena merged commit 9ce987a into develop Jan 29, 2025
@andreslucena andreslucena deleted the fix/conference-media-links branch January 29, 2025 13:04
entantoencuanto added a commit that referenced this pull request Jan 30, 2025
* feature/ephemeral_to_regular_users:
  Add integration test of ephemeral user authorization transfer
  Update test
  Make transferrable authorization when duplicate user is ephemeral
  Revert "Fix answer choices default order" (#13975)
  Fix DownloadYourData core pipeline failures (#13970)
  Update DownloadYourData exports for `decidim-proposals` (#13958)
  Update DownloadYourData exports for `decidim-initiatives` (#13961)
  Fix answer choices default order (#13955)
  Fix 'Conference media link creation form has wrong title' (#13946)
  Add etiquette validator to Debates and Meetings (#13274)
  Enable users to edit their survey answers (#13800)
  Fix "Missing padding-top on proposals page" (#13945)
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
)

* Fix 'Conference media link creation form has wrong title'

* Update decidim-conferences/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena added a commit that referenced this pull request Mar 3, 2025
* Fix 'Conference media link creation form has wrong title'

* Update decidim-conferences/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena
Copy link
Copy Markdown
Member

Adding the no-backport label as this is already in v0.30 and it was already backported to v0.28 and v0.29

@andreslucena andreslucena added the no-backport Pull Requests that should not be backported label Apr 28, 2025
@alecslupu alecslupu added this to the 0.30.0 milestone Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: conferences no-backport Pull Requests that should not be backported release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Conference media link creation form has wrong title

2 participants