Fix "Missing padding-top on proposals page"#13945
Merged
andreslucena merged 4 commits intodevelopfrom Jan 29, 2025
Merged
Conversation
andreslucena
requested changes
Jan 28, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
By doing git blamming, I see this was introduced with #13349. Enabling the voting rules gives too much padding:
Without this PR:
With this PR:
So, can you add a padding-bottom to the voting rules so it doesn't break? Thanks
Contributor
Author
|
@andreslucena this is ready for another round, should be fixed now. |
andreslucena
approved these changes
Jan 29, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
Now it is fixed.
We have talked with @julietapasetti and @carolromero yesterday that we should do a full review of the padding/margins/spacing, as there are places where this is too much (like in this layout), but for now at least this is consistent with the other views (meetings#show, debates#show)
entantoencuanto
added a commit
that referenced
this pull request
Jan 30, 2025
* feature/ephemeral_to_regular_users: Add integration test of ephemeral user authorization transfer Update test Make transferrable authorization when duplicate user is ephemeral Revert "Fix answer choices default order" (#13975) Fix DownloadYourData core pipeline failures (#13970) Update DownloadYourData exports for `decidim-proposals` (#13958) Update DownloadYourData exports for `decidim-initiatives` (#13961) Fix answer choices default order (#13955) Fix 'Conference media link creation form has wrong title' (#13946) Add etiquette validator to Debates and Meetings (#13274) Enable users to edit their survey answers (#13800) Fix "Missing padding-top on proposals page" (#13945)
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
* Fix proposal padding * Fix voting rules issue * Fixing soritition pipeline
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Fix proposal padding * Fix voting rules issue * Fixing soritition pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR fixes the proposal show page padding issue. The issue has been introduced in #13349
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
