Skip to content

Enable users to edit their survey answers#13800

Merged
andreslucena merged 17 commits intodevelopfrom
feature/edit-survey
Jan 29, 2025
Merged

Enable users to edit their survey answers#13800
andreslucena merged 17 commits intodevelopfrom
feature/edit-survey

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jan 2, 2025

🎩 What? Why?

This PR adds the posibility for enduser to edit the the survey answers.

📌 Related Issues

Testing

  1. Change to this branch, restart your server ( a new migration to be added)
  2. Visit admin panel, and edit a survey so an answer can be submitted
  3. Check also "Allow editing answers"
  4. Visit the frontend.
  5. Answer survey
  6. See the edit button ( press it )
  7. Change your answers
  8. Save
  9. Edit again, see the changes have been saved.

📷 Screenshots

Please add screenshots of the changes you are proposing

image
image
image

♥️ Thank you!

github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2025
@alecslupu alecslupu added the project: 2024-api Barcelona Supercomputing Center contract label Jan 16, 2025
@alecslupu alecslupu changed the title Add setting in surveys' steps for allow_editing_answers Enable users to edit their survey answers Jan 16, 2025
@alecslupu alecslupu marked this pull request as ready for review January 16, 2025 14:17
@alecslupu alecslupu assigned alecslupu and andreslucena and unassigned alecslupu Jan 16, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena , i guess we could start the discussion on this PR.

github-actions[bot]
github-actions bot previously approved these changes Jan 27, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena , i would change the text in admin from "Allow answers":
image

to something more understandable:

image

Having this suggestion, the help text could be irrelevant ... What do you think? cc @decidim/product , @carolromero

github-actions[bot]
github-actions bot previously approved these changes Jan 27, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena , this is ready for another round

@carolromero
Copy link
Copy Markdown
Member

@alecslupu good suggestion, let's go with that.

github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Jan 28, 2025

@alecslupu good suggestion, let's go with that.

Done in f8ef57e

image

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andreslucena
Copy link
Copy Markdown
Member

Merging with the only failure of codecov

@andreslucena
Copy link
Copy Markdown
Member

Wops wrong button 😅

@andreslucena andreslucena reopened this Jan 29, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

Wops wrong button 😅

@andreslucena, this is ready for another push :)

image

@andreslucena andreslucena merged commit dead731 into develop Jan 29, 2025
@andreslucena andreslucena deleted the feature/edit-survey branch January 29, 2025 10:15
entantoencuanto added a commit that referenced this pull request Jan 30, 2025
* feature/ephemeral_to_regular_users:
  Add integration test of ephemeral user authorization transfer
  Update test
  Make transferrable authorization when duplicate user is ephemeral
  Revert "Fix answer choices default order" (#13975)
  Fix DownloadYourData core pipeline failures (#13970)
  Update DownloadYourData exports for `decidim-proposals` (#13958)
  Update DownloadYourData exports for `decidim-initiatives` (#13961)
  Fix answer choices default order (#13955)
  Fix 'Conference media link creation form has wrong title' (#13946)
  Add etiquette validator to Debates and Meetings (#13274)
  Enable users to edit their survey answers (#13800)
  Fix "Missing padding-top on proposals page" (#13945)
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
* Add initial functionality

* Persist the form editing

* Fixing pipeline

* Fixing locales

* Small refactory

* Fixing pipeline

* Add specs for edit survey

* Move field, add help_text in admin form

* Add method documentation

* Restrict visitor access to edit survey form

* Add more questions to the specs

* Fix specs

* Change Copy
andreslucena pushed a commit that referenced this pull request Mar 3, 2025
* Add initial functionality

* Persist the form editing

* Fixing pipeline

* Fixing locales

* Small refactory

* Fixing pipeline

* Add specs for edit survey

* Move field, add help_text in admin form

* Add method documentation

* Restrict visitor access to edit survey form

* Add more questions to the specs

* Fix specs

* Change Copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: forms module: surveys project: 2024-api Barcelona Supercomputing Center contract

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Allow editing answers in surveys

3 participants