Skip to content

Redesign: groups conversations + activate redesign in decidim core tests (old ci workflows)#11073

Merged
ferblape merged 73 commits intofeature/redesignfrom
feature/redesign-workflows
Jul 3, 2023
Merged

Redesign: groups conversations + activate redesign in decidim core tests (old ci workflows)#11073
ferblape merged 73 commits intofeature/redesignfrom
feature/redesign-workflows

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented Jun 20, 2023

🎩 What? Why?

This PR:

  • Enables redesign in core tests and fixes failing ones
  • Applies redesign to conversations from groups and adapts related tests

📌 Related Issues

Testing

To test conversations inside groups:

♥️ Thank you!

@entantoencuanto entantoencuanto changed the base branch from develop to feature/redesign June 20, 2023 17:59
@entantoencuanto entantoencuanto added the project: redesign Barcelona City Council contract label Jun 20, 2023
@entantoencuanto entantoencuanto changed the title Feature/redesign workflows Redesign: enable core ci workflows Jun 20, 2023
jorgeatgu and others added 23 commits June 22, 2023 10:39
@entantoencuanto entantoencuanto force-pushed the feature/redesign-workflows branch from 5e8e36c to df45adc Compare June 28, 2023 14:56
@entantoencuanto entantoencuanto force-pushed the feature/redesign-workflows branch from df45adc to 0e7b4d6 Compare June 28, 2023 15:36
* feature/redesign:
  Redesign: home (#10920)
  Remove widgets and embeds (#11096)
  Redesign / Complete card G cell specs (#11094)
  Redesign: processes assemblies metadata content blocks (#10637)
  Redesign: vertical margin inside the callouts (#11071)
  Redesign / Update package-lock  (#11091)
  Use the component name in the sidebar title (#11088)
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 29, 2023

The pending tests are very specific, we have extracted it to #11101 so we can move forward with the review.

@entantoencuanto entantoencuanto marked this pull request as ready for review June 29, 2023 08:58
@entantoencuanto entantoencuanto requested a review from furilo June 29, 2023 08:58
@furilo furilo requested a review from a team June 29, 2023 15:21
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 29, 2023

@fblupi you can start with the review, as the front-end depending part is small.

@Crashillo Crashillo linked an issue Jun 29, 2023 that may be closed by this pull request
5 tasks
@ferblape ferblape changed the title Redesign: enable core ci workflows Redesign / Applies redesign on groups conversations + activate redesign in decidim core tests (old ci workflows) Jun 30, 2023
@andreslucena andreslucena changed the title Redesign / Applies redesign on groups conversations + activate redesign in decidim core tests (old ci workflows) Redesign: groups conversations + activate redesign in decidim core tests (old ci workflows) Jun 30, 2023
Copy link
Copy Markdown
Member

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @entantoencuanto, in mobile there is an horizontal scroll in some conversations (not all from what I've seen). Here's an example: https://decidim-redesign.populate.tools/profiles/anon-ug-28078/conversations/375
imatge

@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jun 30, 2023

Fixed @carolromero

@ferblape ferblape merged commit 4255ff1 into feature/redesign Jul 3, 2023
@ferblape ferblape deleted the feature/redesign-workflows branch July 3, 2023 08:40
entantoencuanto added a commit that referenced this pull request Jul 3, 2023
* feature/redesign:
  Redesign: vertical flow for each sort of layout (#10883)
  Redesign: visual adjustments (#11100)
  Redesign: search + Card S (#11087)
  Redesign: adjust context links (#11095)
  Redesign: groups conversations + activate redesign in decidim core tests (old ci workflows) (#11073)
  style error pages (#11108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Redesign doorkeeper and devise forms Redesign / Activate redesign in core

6 participants