Skip to content

Integrate reported users in Global moderation#10018

Merged
ahukkanen merged 6 commits intodecidim:developfrom
i-need-another-coffee:ale/change-reported-users
Dec 9, 2022
Merged

Integrate reported users in Global moderation#10018
ahukkanen merged 6 commits intodecidim:developfrom
i-need-another-coffee:ale/change-reported-users

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Nov 2, 2022 •
edited
Loading

🎩 What? Why?

As an administrator, when a participant is reported I can’t see them in the “Global moderation” panel. This PR is moving the moderated users panel from user's to Global moderation.

Please refer to #10034 for additional details.

Ref: SPAM02

📌 Related Issues

Link your PR to an issue

Testing

  1. Enter the application
  2. Report some content and some users
  3. Go to admin dashboard. In the participants section you should not see reported users
  4. Go to Global moderation. You should see reported users section, and menu counter

📷 Screenshots

Please add screenshots of the changes you're proposing
Participants section
Global moderation

♥️ Thank you!

@alecslupu alecslupu marked this pull request as ready for review November 2, 2022 06:56
@alecslupu alecslupu force-pushed the ale/change-reported-users branch from 1538557 to 51c8f2d Compare November 2, 2022 07:37
@alecslupu alecslupu force-pushed the ale/change-reported-users branch from 51c8f2d to 95dbad8 Compare November 8, 2022 21:18
@alecslupu alecslupu mentioned this pull request Nov 8, 2022
Merged
@alecslupu alecslupu self-assigned this Nov 9, 2022
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Nov 14, 2022

@alecslupu I've reviewed this one with @carolromero and we've found a couple of changes in the general flow that weren't explicitly in the original Acceptance Criterias:

  • Block user form should be moved too. How it's working now is that this still is on the /users/ section, and it breaks the expectation that you're in the "Global moderations" section:

Selection_411

Can you make those changes please? Thanks

@alecslupu alecslupu force-pushed the ale/change-reported-users branch 3 times, most recently from 19bf63b to e00525b Compare November 17, 2022 13:56
@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Nov 17, 2022

@andreslucena All the requested changes have been done. Can you review this ?

andreslucena
andreslucena requested changes Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we had in mind, great job 👏🏽 !!

I have a couple suggestions, can you give them an eye 🙏🏽 ?

@alecslupu alecslupu force-pushed the ale/change-reported-users branch 3 times, most recently from ccc5a70 to f22b2de Compare November 21, 2022 17:57
andreslucena
andreslucena previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

ahukkanen
ahukkanen requested changes Nov 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, really nice change.

As a bonus, I noticed it fixes this layout bug too 👍
Before

After

Just a really small change request, as per this requirement in the original issue:

To have a link in the side menu to "Participants" with the view of "Reported users" and to have the current "Global moderations" view renamed to "Content moderations" (see screenshot).

Could you change this string to "Participants":

decidim/decidim-admin/config/locales/en.yml

Line 563 in 0a5cd79

reported_users: Reported Users

And this string to "Listing participants":

decidim/decidim-admin/config/locales/en.yml

Line 662 in 0a5cd79

title: Listing reported users

Please note that you may need to apply this change to some specs as well (I would imagine).

@alecslupu alecslupu force-pushed the ale/change-reported-users branch from 98206de to 402acd8 Compare December 9, 2022 18:29
@alecslupu alecslupu requested a review from ahukkanen December 9, 2022 18:32
ahukkanen
ahukkanen approved these changes Dec 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ahukkanen ahukkanen merged commit db91cf3 into decidim:develop Dec 9, 2022
entantoencuanto added a commit that referenced this pull request Dec 16, 2022
@entantoencuanto
Merge branch 'develop' into feature/redesign-meetings
65addab 
* develop:
  Redesign: action buttons (#9852)
  Integrate reported users in Global moderation (#10018)
  Fix resource_icon with component or manifest nil (#10134)
  Revent Docker actions to Ubuntu 20.04 due to OpenSSL issues (#10142)
  Fix push notifications URL method (#10017)
  Fix typo in README (#10110)
  Add correct call for conference speaker (#10061)
  Fix missing fields on duplicate meetings functionality (#9899)
  Fix translations missing on admin log (#9889)
@alecslupu alecslupu deleted the ale/change-reported-users branch January 11, 2023 11:51
@andreslucena andreslucena mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

@andreslucena andreslucena andreslucena left review comments

@roxanaopr roxanaopr Awaiting requested review from roxanaopr

Assignees

@alecslupu alecslupu

Labels

module: admin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate "reported participants" in Global moderations

3 participants

@alecslupu @andreslucena @ahukkanen