Fix resource_icon with component or manifest nil#10134
Merged
Conversation
ahukkanen
approved these changes
Dec 9, 2022
entantoencuanto
added a commit
that referenced
this pull request
Dec 16, 2022
* develop: Redesign: action buttons (#9852) Integrate reported users in Global moderation (#10018) Fix resource_icon with component or manifest nil (#10134) Revent Docker actions to Ubuntu 20.04 due to OpenSSL issues (#10142) Fix push notifications URL method (#10017) Fix typo in README (#10110) Add correct call for conference speaker (#10061) Fix missing fields on duplicate meetings functionality (#9899) Fix translations missing on admin log (#9889)
This was referenced Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix errors
undefined method manifest for nil:NilClassandundefined method icon for nil:NilClasswhen the resource component is nil (e.g., initiatives).Testing
In a fresh installation of decidim 0.27 with the initiatives module installed. Log in with a user and leave a comment in an initiative. Log in with another user and reply to the comment previously created. Log in again with the first user and go to the notifications page. You will see an
undefined method for nil:NilClasserror.📷 Screenshots