Conversation
cc7385e to
31ff3c3
Compare
|
@entantoencuanto I noticed this console error: |
a2337b7 to
0f09ed7
Compare
420c466
|
Yesterday I had to include a commit, unrelated with this matter, but whose changes were introduced by this PR. That fact, automatically dismisses the approval reviews. Keep that in mind, @decidim/maintainers, when you've to review a PR. We'll request it again to them (:arrows_counterclockwise: refresh button) if it was necessary. Otherwise, as this one, we'll inform to you that the |
ahukkanen
left a comment
There was a problem hiding this comment.
One more bug I have discovered from the follow button, please see below.
I have seen this issue multiple times and before I thought it would be related to some browser cache but in this situation I am 100% sure I did not have any browser cache because I cleared it before arriving to the redesign app.
This tends to happen only on fresh browser sessions, when you arrive to the website. After you've used the follow button once, it works fine after that.
|
To replicate the above issue I just did the following:
|
It seems most of the comments from this review were resolved or moved to the pending issues. One comment regarding the comment icons seems out of scope based on the discussion.
* develop: Redesign: action buttons (#9852) Integrate reported users in Global moderation (#10018) Fix resource_icon with component or manifest nil (#10134) Revent Docker actions to Ubuntu 20.04 due to OpenSSL issues (#10142) Fix push notifications URL method (#10017) Fix typo in README (#10110) Add correct call for conference speaker (#10061) Fix missing fields on duplicate meetings functionality (#9899) Fix translations missing on admin log (#9889)
* develop: Redesign: action buttons (#9852)
🎩 What? Why?
Move some common actions to cells independent cells
Sample page: https://decidim-redesign.populate.tools/processes/book-bless/f/9/posts/5
Closes #9930