Skip to content

Redesign: action buttons#9852

Merged
ahukkanen merged 133 commits intodevelopfrom
feature/redesign-action-buttons
Dec 16, 2022
Merged

Redesign: action buttons#9852
ahukkanen merged 133 commits intodevelopfrom
feature/redesign-action-buttons

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Sep 23, 2022

🎩 What? Why?

Move some common actions to cells independent cells

Sample page: https://decidim-redesign.populate.tools/processes/book-bless/f/9/posts/5

Closes #9930

♥️ Thank you!

@Crashillo Crashillo added the project: redesign Barcelona City Council contract label Sep 23, 2022
@entantoencuanto entantoencuanto force-pushed the feature/redesign-action-buttons branch from cc7385e to 31ff3c3 Compare September 29, 2022 19:26
@Crashillo
Copy link
Copy Markdown
Contributor Author

@entantoencuanto I noticed this console error: this.dropdown is null when you open for instance blogs. It's due to endorsers_list_button_cell includes an empty button, which data-attributes require another code snippet, missing in the DOM. The solution is about removing the empty button from the DOM whenever the condition-to-hide is fulfilled (in this case, no endorsers)

@entantoencuanto entantoencuanto force-pushed the feature/redesign-action-buttons branch from a2337b7 to 0f09ed7 Compare December 12, 2022 17:24
@Crashillo Crashillo requested a review from ahukkanen December 13, 2022 08:46
@furilo furilo self-requested a review December 13, 2022 08:47
furilo
furilo previously approved these changes Dec 13, 2022
@entantoencuanto entantoencuanto self-requested a review December 13, 2022 10:06
ferblape
ferblape previously approved these changes Dec 13, 2022
@Crashillo Crashillo dismissed stale reviews from ferblape, entantoencuanto, and furilo via 420c466 December 13, 2022 17:29
@Crashillo
Copy link
Copy Markdown
Contributor Author

Yesterday I had to include a commit, unrelated with this matter, but whose changes were introduced by this PR. That fact, automatically dismisses the approval reviews.

Keep that in mind, @decidim/maintainers, when you've to review a PR. We'll request it again to them (:arrows_counterclockwise: refresh button) if it was necessary. Otherwise, as this one, we'll inform to you that the show reviewing process must go on

@entantoencuanto entantoencuanto self-requested a review December 14, 2022 09:24
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more bug I have discovered from the follow button, please see below.

I have seen this issue multiple times and before I thought it would be related to some browser cache but in this situation I am 100% sure I did not have any browser cache because I cleared it before arriving to the redesign app.

This tends to happen only on fresh browser sessions, when you arrive to the website. After you've used the follow button once, it works fine after that.

@ahukkanen
Copy link
Copy Markdown
Contributor

ahukkanen commented Dec 15, 2022

To replicate the above issue I just did the following:

  1. Close any existing browser windows you may have open
  2. Open Firefox (just to confirm it's not anything regarding my Chrome local data or cache)
  3. Clear all browser data including "Site Settings" and "Offline website data" from time range of "Everything" (in a normal Firefox window click CTRL+SHIFT+DEL to open that window, click all checkboxes from there)
  4. Open a new private browsing window (CTRL+SHIFT+P)
  5. Go to https://decidim-redesign.populate.tools/processes/book-bless/f/9/posts/5
  6. Login to the site by clicking the link at the top right corner of the page
  7. Click the "Follow" button on the blog post page

@ahukkanen ahukkanen mentioned this pull request Dec 16, 2022
13 tasks
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ahukkanen ahukkanen dismissed andreslucena’s stale review December 16, 2022 13:44

It seems most of the comments from this review were resolved or moved to the pending issues. One comment regarding the comment icons seems out of scope based on the discussion.

@ahukkanen ahukkanen merged commit b349705 into develop Dec 16, 2022
@ahukkanen ahukkanen deleted the feature/redesign-action-buttons branch December 16, 2022 13:44
entantoencuanto added a commit that referenced this pull request Dec 16, 2022
* develop:
  Redesign: action buttons (#9852)
  Integrate reported users in Global moderation (#10018)
  Fix resource_icon with component or manifest nil (#10134)
  Revent Docker actions to Ubuntu 20.04 due to OpenSSL issues (#10142)
  Fix push notifications URL method (#10017)
  Fix typo in README (#10110)
  Add correct call for conference speaker (#10061)
  Fix missing fields on duplicate meetings functionality (#9899)
  Fix translations missing on admin log (#9889)
entantoencuanto added a commit that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Redesign: Pending Turbo

9 participants