Fix missing fields on duplicate meetings functionality#9899
Fix missing fields on duplicate meetings functionality#9899ahukkanen merged 8 commits intodecidim:developfrom
Conversation
|
I changed the PR description a bit so its easier to review. |
|
This is solving the original report, but as far as I see, there are others fields that aren't in the This is the "Duplicate meeting" form: And this is the original Edit form with all the differences highlighted: As a summary:
As this is getting bigger than expected initially, I see two options:
So, whatever you prefer @alecslupu, feel free to say no if you don't have the time. |
|
@andreslucena , the following extra fields have been added : There may be some others like |
|
You're adding them to the Command, but as far as I understand they also need to be added in the Form (https://github.com/decidim/decidim/blob/develop/decidim-meetings/app/commands/decidim/meetings/admin/copy_meeting.rb). There should also be the required validation. The help texts (arrows in my last screenshot) are still missing. They need to be added at https://github.com/decidim/decidim/tree/develop/decidim-meetings/app/views/decidim/meetings/admin/meeting_copies/_form.html.erb We would also need specs for both classes (Form and Command). Thanks! |
andreslucena
left a comment
There was a problem hiding this comment.
I really like this approach, as we'll tackle the problem from the root: we just forgot that this feature exist and when we change something in the new form we don't update that in the copy form.
By removing this duplication we'll just fix this problem now and on the future too. Awesome! 🚀
I have a couple suggestions.
decidim-meetings/app/views/decidim/meetings/admin/meeting_copies/new.html.erb
Show resolved
Hide resolved
decidim-meetings/app/forms/decidim/meetings/admin/meeting_copy_form.rb
Outdated
Show resolved
Hide resolved
andreslucena
left a comment
There was a problem hiding this comment.
Two more small changes and we're good to go!
decidim-meetings/app/forms/decidim/meetings/admin/meeting_copy_form.rb
Outdated
Show resolved
Hide resolved
decidim-meetings/app/forms/decidim/meetings/admin/meeting_form.rb
Outdated
Show resolved
Hide resolved
ahukkanen
left a comment
There was a problem hiding this comment.
Nice! All fields copied as expected.
* develop: Redesign: action buttons (#9852) Integrate reported users in Global moderation (#10018) Fix resource_icon with component or manifest nil (#10134) Revent Docker actions to Ubuntu 20.04 due to OpenSSL issues (#10142) Fix push notifications URL method (#10017) Fix typo in README (#10110) Add correct call for conference speaker (#10061) Fix missing fields on duplicate meetings functionality (#9899) Fix translations missing on admin log (#9889)


🎩 What? Why?
Fix the copy meeting functionality in 0.28.
📌 Related Issues
Testing