Fix translations missing on admin log#9889
Merged
ahukkanen merged 2 commits intodecidim:developfrom Nov 29, 2022
Merged
Conversation
When we deleted a registration type on a conference and went to the Admin activity log, we found a translation missing log in the log. It seems that the definition of remove log does not exist in locale files. Therefore, we added the definition in the yaml files.
Member
|
Thanks for the PR @M-Yamashita01 👍🏽 I've just checked it out locally and found out that we're also missing
Would you be so kind of adding this one too 🙏🏽? Thanks |
Contributor
Author
|
@andreslucena |
andreslucena
approved these changes
Nov 18, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
I thought we already had merged this one, sorry!!
LGTM 👍🏽
ahukkanen
approved these changes
Nov 29, 2022
entantoencuanto
added a commit
that referenced
this pull request
Dec 16, 2022
* develop: Redesign: action buttons (#9852) Integrate reported users in Global moderation (#10018) Fix resource_icon with component or manifest nil (#10134) Revent Docker actions to Ubuntu 20.04 due to OpenSSL issues (#10142) Fix push notifications URL method (#10017) Fix typo in README (#10110) Add correct call for conference speaker (#10061) Fix missing fields on duplicate meetings functionality (#9899) Fix translations missing on admin log (#9889)
This was referenced Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When we deleted a registration type on a conference and went to the Admin activity log, we found a translation missing log in the log.
It seems that the definition of remove log does not exist in locale files.
Therefore, we added the definition in the yaml files.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you're proposing
