Add user moderation template#10016
Merged
ahukkanen merged 11 commits intodecidim:developfrom Dec 21, 2022
Merged
Conversation
This was referenced Nov 2, 2022
4c4e923 to
2e3af04
Compare
5300bc5 to
8d8099f
Compare
Contributor
Author
|
@andreslucena can you review this ? |
Member
|
I have a couple suggestions:
|
andreslucena
requested changes
Nov 24, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Some other things that I found out while reviewing this, can you check them out please? Thanks
decidim-templates/spec/system/admin/admin_chooses_block_user_template_spec.rb
Outdated
Show resolved
Hide resolved
decidim-templates/app/packs/src/decidim/templates/admin/block_template_chooser.js
Outdated
Show resolved
Hide resolved
defc487 to
6697ed8
Compare
188c130 to
a540b5c
Compare
a540b5c to
ff1b766
Compare
andreslucena
previously approved these changes
Dec 12, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've seen just a tiny capital letter change but apart from that LGTM 👍🏽 👍🏽
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Contributor
Author
|
@andreslucena I have done the changes requested |
ahukkanen
requested changes
Dec 20, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Looks really good, nice work!
Found a couple places to improve, particularly the added wait_for_ajax method in the specs. Other comments are just minor improvement ideas.
decidim-templates/spec/system/admin/admin_chooses_block_user_template_spec.rb
Outdated
Show resolved
Hide resolved
decidim-templates/app/controllers/decidim/templates/admin/block_user_templates_controller.rb
Outdated
Show resolved
Hide resolved
decidim-templates/app/controllers/decidim/templates/admin/block_user_templates_controller.rb
Outdated
Show resolved
Hide resolved
...-templates/app/views/decidim/templates/admin/block_user_templates/_template_chooser.html.erb
Outdated
Show resolved
Hide resolved
fb56000 to
b336e68
Compare
ahukkanen
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR adds a new admin section in the templates area, to allow admins to fill in moderation templates, that can be used later. It automatically supports multiple translations, rendering back to the interface the template in admin's language (current_locale of current logged in user).
Please refer to: #10033 for further details.
This addresses SPAM01
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you're proposing
