Skip to content

rgw multisite: bucket reshard work in progress#39002

Merged
cbodley merged 194 commits intomainfrom
wip-rgw-multisite-reshard
Jun 2, 2022
Merged

rgw multisite: bucket reshard work in progress#39002
cbodley merged 194 commits intomainfrom
wip-rgw-multisite-reshard

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Jan 21, 2021 •
edited by adamemerson
Loading

stable working branch for bucket resharding support in multisite

design document: https://github.com/ceph/ceph/blob/master/src/doc/rgw/multisite-reshard.md

todo

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@cbodley cbodley added the rgw label Jan 21, 2021
@github-actions github-actions bot added the tests label Jan 21, 2021
@mattbenjamin
Copy link
Contributor

mattbenjamin commented Jan 25, 2021

@adam @cbodley this PR seems like it needs an item in the backlog? #38230

@cbodley
Copy link
Contributor Author

cbodley commented Jan 25, 2021

@adam @cbodley this PR seems like it needs an item in the backlog? #38230

@mattbenjamin this pr is only tracking the multisite resharding work. @adamemerson's 'FIFO the Datalog' work merged for pacific, so i'd rather we track the related backports as tracker issues and BZs

@github-actions
Copy link

github-actions bot commented Jan 27, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@cbodley cbodley force-pushed the wip-rgw-multisite-reshard branch from d26c424 to 19ce2fb Compare January 28, 2021 19:00
@cbodley cbodley force-pushed the wip-rgw-multisite-reshard branch from 8632248 to f329d99 Compare February 4, 2021 22:16
@cbodley cbodley mentioned this pull request Feb 5, 2021
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Feb 7, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

This was referenced Feb 8, 2021
Closed
Closed
Closed
@mattbenjamin
Copy link
Contributor

mattbenjamin commented Mar 29, 2021

@cbodley @smanjara @adamemerson is it possible we could update the still open items w/owners where an owner exists?

@adamemerson adamemerson self-assigned this Apr 29, 2021
@adamemerson adamemerson force-pushed the wip-rgw-multisite-reshard branch from 36c2959 to 95355ab Compare May 12, 2021 16:05
@cbodley cbodley mentioned this pull request Jun 3, 2021
Closed
This was referenced Jun 14, 2021
Closed
Closed
@github-actions
Copy link

github-actions bot commented Jun 23, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@cbodley cbodley force-pushed the wip-rgw-multisite-reshard branch from 7aaf0f5 to 679ce4a Compare August 23, 2021 12:40
@github-actions github-actions bot added cephfs Ceph File System crimson labels May 27, 2022
@cbodley
Copy link
Contributor Author

cbodley commented May 27, 2022

seeing teuthology failures on FAIL: s3tests_boto3.functional.test_s3.test_set_bucket_tagging, so i rebased over current main to pick up #46167. rebased without conflict

@cbodley cbodley removed the request for review from a team May 27, 2022 19:53
@cbodley cbodley changed the base branch from master to main May 27, 2022 19:53
@cbodley cbodley removed the request for review from a team May 27, 2022 20:30
@adamemerson
Copy link
Contributor

adamemerson commented May 31, 2022

Jenkins, test API

@cbodley
Copy link
Contributor Author

cbodley commented May 31, 2022

failed qa in https://pulpito.ceph.com/cbodley-2022-05-27_19:16:02-rgw-wip-rgw-multisite-reshard-distro-default-smithi/

@cbodley
Copy link
Contributor Author

cbodley commented May 31, 2022

failures from workunits/rgw/run-reshard.sh:

2022-05-27T19:45:32.492 INFO:tasks.workunit.client.0.smithi114.stderr:Traceback (most recent call last):
2022-05-27T19:45:32.492 INFO:tasks.workunit.client.0.smithi114.stderr:  File "/home/ubuntu/cephtest/clone.client.0/qa/workunits/rgw/test_rgw_reshard.py", line 316, in <module>
2022-05-27T19:45:32.492 INFO:tasks.workunit.client.0.smithi114.stderr:    main()
2022-05-27T19:45:32.492 INFO:tasks.workunit.client.0.smithi114.stderr:  File "/home/ubuntu/cephtest/clone.client.0/qa/workunits/rgw/test_rgw_reshard.py", line 296, in main
2022-05-27T19:45:32.492 INFO:tasks.workunit.client.0.smithi114.stderr:    assert len(json_op) == 1
2022-05-27T19:45:32.492 INFO:tasks.workunit.client.0.smithi114.stderr:AssertionError

cbodley added 2 commits May 31, 2022 17:29
@cbodley
test/rgw: fix test case for empty-OLH-name cleanup
47913cb 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
rgw: restore check for empty olh name on reshard
bed7051 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Copy link
Contributor Author

cbodley commented Jun 1, 2022

not sure why this multisite test is failing:

2022-06-01T03:13:06.134 DEBUG:teuthology.orchestra.run.smithi063:> adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage radosgw-admin --log-to-stderr --format json -n client.0 --cluster c1 bucket reshard --bucket qmhdzr-49 --num-shards 3 --yes-i-really-mean-it --cluster c1 --debug-rgw 0 --debug-ms 0
2022-06-01T03:13:06.190 INFO:teuthology.orchestra.run.smithi063.stderr:ignoring --setuser ceph since I am not root
2022-06-01T03:13:06.206 INFO:teuthology.orchestra.run.smithi063.stderr:ignoring --setgroup ceph since I am not root
2022-06-01T03:13:06.320 INFO:teuthology.orchestra.run.smithi063.stderr:The zonegroup 'a' does not have the resharding feature enabled.
2022-06-01T03:13:06.322 DEBUG:teuthology.orchestra.run:got remote process result: 95
2022-06-01T03:13:06.400 INFO:tasks.rgw_multisite_tests:rgw_multi.tests.test_bucket_reshard_index_log_trim ... FAIL

@cbodley
test/rgw/multisite: enable zonegroup resharding feature
8e51eb8 
qa/tasks/rgw_multisite.py uses 'zonegroup set' to create zonegroups from
their json format. this doesn't enable any of the supported zonegroup
features by default, so this adds the 'enabled_features' field to the
json representations

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Copy link
Contributor Author

cbodley commented Jun 2, 2022

mostly passed qa in https://pulpito.ceph.com/cbodley-2022-06-01_19:25:46-rgw-master-distro-default-smithi/

@cbodley cbodley requested a review from mattbenjamin June 2, 2022 20:03
mattbenjamin
mattbenjamin approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not worthy!

@cbodley cbodley merged commit 63f84c5 into main Jun 2, 2022
@cbodley cbodley deleted the wip-rgw-multisite-reshard branch June 2, 2022 20:04
@yuvalif
Copy link
Contributor

yuvalif commented Jun 3, 2022

this deserves a celebration 🥳 🎉

This was referenced May 30, 2023
Merged
Merged
@liangmingyuanneo liangmingyuanneo mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamemerson adamemerson adamemerson left review comments

@mattbenjamin mattbenjamin mattbenjamin approved these changes

Assignees

@adamemerson adamemerson

Labels

build/ops common documentation rgw tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cbodley @mattbenjamin @vumrao @adamemerson @yuvalif @yuriw @ivancich @kapandya