rgw multisite reshard: retry writes to bucket instance on ECANCELED#44990
Merged
cbodley merged 9 commits intoceph:wip-rgw-multisite-reshardfrom Feb 14, 2022
Merged
Conversation
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
…commit_target_layout Signed-off-by: Casey Bodley <cbodley@redhat.com>
This was referenced Feb 11, 2022
adamemerson
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates the three places in bucket reshard that write to bucket instance metadata:
init_target_layout(),revert_target_layout(), andcommit_reshard()ECANCELEDerrors from cls_version are handled with a retry loop similar toretry_raced_bucket_write()fromrgw_op.cc. each time we seeECANCELED, we re-read the bucket instance metadata and check for races with other reshards or reshard cancelation, then re-apply the mutation to bucket_infoi chose not to reuse
retry_raced_bucket_write()here because it requiresrgw::sal::Bucket, and reshard doesn't use sal interfaces yet - switching that would really complicate backportsqa/workunits/rgw/test_rgw_reshard.pyhas reshard test cases with fault injection to test error paths and crash recovery. i extended the test and radosgw-admin to allow injection of theseECANCELEDerrors. the injectedECANCELEDerrors are special because they're only injected once, so the test expects the retry to succeedShow available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox