rgw: Don't erase bucket attributes on trim#44871
Closed
adamemerson wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
Closed
rgw: Don't erase bucket attributes on trim#44871adamemerson wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
adamemerson wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
Conversation
cbodley
reviewed
Feb 2, 2022
Contributor
cbodley
left a comment
There was a problem hiding this comment.
wow, it took me way too many steps to verify that RGWPutBucketInstanceInfoCR actually does call rgw_put_system_obj()
because this only changes a very specific call path, it has low risk of regression elsewhere
i'm still interested in figuring out what the right interface is in the longer term, but i'm happy to have no_change_attrs() as a tool in the meantime
Writing bucket instance info is surprising, as if you pass a null pointer for the attributes, it just erases all the attributes. To avoid disturbing users and other 'system objects', make a special case that we can pass in explicitly. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
5b61462 to
42c7d79
Compare
cbodley
approved these changes
Feb 2, 2022
ivancich
approved these changes
Feb 3, 2022
31 tasks
Contributor
|
merged into wip-rgw-multisite-reshard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing bucket instance info is surprising, as if you pass a null
pointer for the attributes, it just erases all the attributes.
To avoid disturbing users and other 'system objects', make a special
case that we can pass in explicitly.