rgw/multisite: track shard sync status objects per generation#41538
rgw/multisite: track shard sync status objects per generation#41538yuvalif wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
Conversation
f218891 to
6f74dfd
Compare
| } | ||
|
|
||
| return new RGWReadBucketPipeSyncStatusCoroutine(&sc, sync_pairs[num], sync_status, nullptr); | ||
| return new RGWReadBucketPipeSyncStatusCoroutine(&sc, sync_pairs[num], sync_status, nullptr, full_status.incremental_gen); |
There was a problem hiding this comment.
i don't think anything is initializing this full_status. the only other place i see it used is for RGWRemoteBucketManager::init_sync_status_cr() which writes a new one with InitBucketFullSyncStatusCR
i think RGWBucketPipeSyncStatusManager::read_sync_status() needs to read this full_status before trying to read any of the shards
There was a problem hiding this comment.
is this part of our main code path? is this fix needed?
There was a problem hiding this comment.
its called by radosgw-admin bucket sync markers, which is part of the workflow for manual bilog trimming
if bilogs aren't being trimmed automatically (or fast enough), users may have to trim them manually with radosgw-admin bilog trim - and doing that safely (i.e. not trimming entries that haven't yet been processed by sync) requires the markers from the peer zone
speaking of, we should probably document this stuff, especially now that we've made it more complicated
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
Adam's commits merged in #41051, can you please rebase? |
|
This needs a trip to the rebasement. |
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
6f74dfd to
74c10f1
Compare
|
@cbodley and @adamemerson, |
ready to merge. |
|
merged into #39002 |
Signed-off-by: Yuval Lifshitz ylifshit@redhat.com
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox