rgw multisite: prevent reshard from creating too many log generations#43334
Closed
cbodley wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
Closed
rgw multisite: prevent reshard from creating too many log generations#43334cbodley wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
cbodley wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
Conversation
Contributor
Author
|
smoke tested with two mstart.sh clusters, using |
31 tasks
adamemerson
approved these changes
Sep 28, 2021
93d8efd to
2729d7e
Compare
ivancich
approved these changes
Sep 28, 2021
src/rgw/rgw_admin.cc
Outdated
| std::cerr << "bucket '" << bucket->get_name() << "' already has too many " | ||
| "log generations (" << bucket->get_info().layout.logs.size() << ") " | ||
| "from previous reshards that peer zones haven't finished syncing. " | ||
| "resharding is not recommended until the old generations sync, but " |
Member
There was a problem hiding this comment.
Capitalize "r" in "resharding" since it's a new sentence?
Contributor
Author
There was a problem hiding this comment.
caps?? i'm not sure my keyboard has those :D
Contributor
Author
There was a problem hiding this comment.
updated, thanks for the review!
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2729d7e to
366e4da
Compare
Contributor
Author
|
merged into #39002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in multisite, each reshard creates a new log generation, and
RGWBucketInfohas to track all old log generations until other zones finish syncing them. prevent resharding on a bucket once the number of log generations reaches 4. the bucket will become eligible for reshard again once bilog trimming removes a log generationthis adds two separate checks; one in rgw_admin.cc specifically for
radosgw-admin bucket reshard(which supports overriding with--yes-i-really-mean-it), and another inRGWReshard::process_entry()which covers buckets added by dynamic resharding orradosgw-admin reshard addChecklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox