src/test: Addition of reshared bucket disable-enable test#44838
Closed
TRYTOBE8TME wants to merge 159 commits intoceph:wip-rgw-multisite-reshardfrom
Closed
src/test: Addition of reshared bucket disable-enable test#44838TRYTOBE8TME wants to merge 159 commits intoceph:wip-rgw-multisite-reshardfrom
TRYTOBE8TME wants to merge 159 commits intoceph:wip-rgw-multisite-reshardfrom
Conversation
cbodley
reviewed
Jan 31, 2022
Contributor
cbodley
left a comment
There was a problem hiding this comment.
looks great, is it passing for you?
Author
Yeah, it's passing locally but I need to check it on teuthology |
ed8ae85 to
74b6ac6
Compare
b6342d0 to
8800bf7
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
74b6ac6 to
b51c123
Compare
adamemerson
approved these changes
Feb 2, 2022
31 tasks
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
allows other code to spawn this coroutine without having the class definition Signed-off-by: Casey Bodley <cbodley@redhat.com>
RGWShardCollectCR was hard-coded to ignore ENOENT errors and print a 'failed to fetch log status' error message. this moves that logic into a handle_result() virtual function. it also exposes the member variables 'status' and 'max_concurrent' as protected, so they can be consulted or modified by overrides of handle_result() and spawn_next() Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
a coroutine to initialize a bucket for full sync using a new bucket-wide sync status object Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
full sync happens as the bucket level, so the shards will always start in StateIncrementalSync Signed-off-by: Casey Bodley <cbodley@redhat.com>
use an API that does not check for cache inconsistency hence, "WARNING: The bucket info cache is inconsistent" warnings is removed from reshard Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Writing bucket instance info is surprising, as if you pass a null pointer for the attributes, it just erases all the attributes. To avoid disturbing users and other 'system objects', make a special case that we can pass in explicitly. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
And refuse to remove the only log. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
several places were getting the current index layout indirectly with layout.logs.back() and rgw::log_to_index_layout(). use get_current_index() instead so we don't rely on layout.logs, which may be empty for indexless buckets Signed-off-by: Casey Bodley <cbodley@redhat.com>
always verify that logs is not empty before calling logs.back() or logs.front() Signed-off-by: Casey Bodley <cbodley@redhat.com>
RGWSI_BucketIndex_RADOS::handle_overwrite() is already writing the datalog/bilog entries related to BUCKET_DATASYNC_DISABLED RGWBucket::sync() calls handle_overwrite() indirectly from bucket->put_info() when it writes the bucket instance with this new BUCKET_DATASYNC_DISABLED flag, so RGWBucket::sync() shouldn't duplicate those writes here Signed-off-by: Casey Bodley <cbodley@redhat.com>
d0f01cf to
fe5ea5e
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
Fetch the current generation from remote peers and trim the minimum marker on the minimum generation. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
The test includes disable-enable bucket sync along with resharding the bucket. Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
b51c123 to
4e53747
Compare
14 tasks
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
69074e1 to
ef7373f
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
ef7373f to
8a70544
Compare
230c448 to
ede6a85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kalpesh Pandya kapandya@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox