Skip to content

rgw/multisite: fix bucket shard state init function#41337

Closed
yuvalif wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
yuvalif:wip-yuval-fix-init-status-object
Closed

rgw/multisite: fix bucket shard state init function#41337
yuvalif wants to merge 1 commit intoceph:wip-rgw-multisite-reshardfrom
yuvalif:wip-yuval-fix-init-status-object

Conversation

@yuvalif
Copy link
Contributor

@yuvalif yuvalif commented May 14, 2021

  • make sure src/dest shard ids are the same in sync pair
  • copy sync pair by value in coroutine loop

Signed-off-by: Yuval Lifshitz ylifshit@redhat.com

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@yuvalif
rgw/multisite: fix bucket shard state init function
2f18d7a 
* make sure src/dest shard ids are the same in sync pair
* copy sync pair by value in coroutine loop

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
@yuvalif yuvalif requested a review from cbodley May 14, 2021 09:33
@yuvalif
Copy link
Contributor Author

yuvalif commented May 14, 2021

when multisite test suite running locally, the following tests fail:

  • test_bucket_sync_disable - expected since disable/enable is not implemented yet
  • test_bucket_sync_disable_enable - expected since disable/enable is not implemented yet
  • test_bucket_sync_enable_right_after_disable - expected since disable/enable is not implemented yet
  • test_zg_master_zone_delete - @cbodley is this expected?

@yuvalif
Copy link
Contributor Author

yuvalif commented May 14, 2021

@cbodley is this a similar issue that needs to be fixed as well?

@yuvalif yuvalif mentioned this pull request May 14, 2021
Merged
31 tasks
@cbodley
Copy link
Contributor

cbodley commented May 14, 2021

@cbodley is this a similar issue that needs to be fixed as well?

it looks like CheckAllBucketShardStatusIsIncremental is passing that reference through to the RGWReadBucketPipeSyncStatusCoroutine ctor, which uses it in RGWBucketPipeSyncStatusManager::inc_status_oid() to generate the object name. it's not storing the reference, so i think it's okay

@yuvalif
Copy link
Contributor Author

yuvalif commented May 14, 2021

@cbodley is this a similar issue that needs to be fixed as well?

it looks like CheckAllBucketShardStatusIsIncremental is passing that reference through to the RGWReadBucketPipeSyncStatusCoroutine ctor, which uses it in RGWBucketPipeSyncStatusManager::inc_status_oid() to generate the object name. it's not storing the reference, so i think it's okay

the question was not on storing the name. it was in incrementing the shard id for source and dest in line 2999:

sync_pair.dest_bs.shard_id = shard++;

@cbodley
Copy link
Contributor

cbodley commented May 14, 2021

okay yeah, that's probably broken too

@cbodley
Copy link
Contributor

cbodley commented May 14, 2021

thanks! i added that fix too, and merged your commit into merged into wip-rgw-multisite-reshard

@cbodley cbodley closed this May 14, 2021
@yuvalif
Copy link
Contributor Author

yuvalif commented May 15, 2021

thanks! i added that fix too, and merged your commit into merged into wip-rgw-multisite-reshard

thanks @cbodley !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

No one assigned

Labels

bug-fix rgw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuvalif @cbodley