feat: mailhog fixture by shivamklr · Pull Request #10606 · calcom/cal.com

shivamklr · 2023-08-04T18:25:26Z

What does this PR do?

This PR is a followup on these PRs, #10521 and #10637.
This PR is a PoC for mailhog that can be used to assert emails.

Type of change

Chore/Test (refactoring code, technical debt, workflow improvements)

How should this be tested?

Make sure the mailhog container is running. Ideally, it should run withyarn dx.
The default env variables should work EMAIL_SERVER_HOST='localhost' and EMAIL_SERVER_PORT=1025.
Test booking-pages.e2e.ts

vercel · 2023-08-04T18:25:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 11, 2023 6:58pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 11, 2023 6:58pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 11, 2023 6:58pm

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview	Aug 11, 2023 6:58pm
qa	⬜️ Ignored (Inspect)	Visit Preview	Aug 11, 2023 6:58pm
ui	⬜️ Ignored (Inspect)	Visit Preview	Aug 11, 2023 6:58pm

github-actions · 2023-08-04T18:25:39Z

Thank you for following the naming conventions! 🙏

github-actions · 2023-08-04T18:32:53Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-08-04T18:33:58Z

Current Playwright Test Results Summary

✅ 115 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/11/2023 06:55:41pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: b9f6ea5

Started: 08/11/2023 06:53:44pm UTC

⚠️ Flakes

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route Retry 1 • Initial Attempt	0% (0) 0 / 308 runs failed over last 7 days	2.60% (8) 8 / 308 runs flaked over last 7 days

📄 packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields Retry 1 • Initial Attempt	0.97% (3) 3 / 310 runs failed over last 7 days	7.42% (23) 23 / 310 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	5.10% (16) 16 / 314 runs failed over last 7 days	94.90% (298) 298 / 314 runs flaked over last 7 days

View Detailed Build Results

socket-security · 2023-08-04T18:34:00Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
mailhog	4.16.0	None	`+0`	51.2 kB	blueimp

alwaysmeticulous · 2023-08-04T18:35:59Z

🤖 Meticulous spotted visual differences in 22 of 166 screens tested: view and approve differences detected.

_{Last updated for commit b9f6ea5. This comment will update as new commits are pushed.}

nicktrn · 2023-08-04T20:48:34Z

leog

Code looks good, very good addition to our test suite.
I just couldn't run it locally to verify it works as expected, getting a Error: connect ECONNREFUSED ::1:8025 error. Is there any extra step needed to make it work?

nicktrn · 2023-08-11T15:20:31Z

@leog Mailhog needs to be running for this to work. I've taken a different approach in #10560 where playwright starts a mail server instance directly. Would be worth discussing pros and cons.

leog

Got it to work using yarn dx and since the changes to make it work in GH actions were taken in a different PR already merged, this looks good to me now. Thanks!

* feat: mailhog fixture * fix: nodemailer to dispatch emails with e2e env * fix: remove space from email subject * feat: fixture getFirstEventAsOwner * feat: assert email subjects

* Init + get timezone + offset data agh * Add 12/24h mode - style correctly * User users timezone + working hours. Still some stuff to figure out * Multiple working hours * move calc to once per day * Demo with two users and differnt timezones * availabillity control tab via search params * WIP hover overlay * THIS WORKS ISH * fix: multiple duration getSchedule calls [CAL-2336] (#10709) Co-authored-by: Omar López <zomars@me.com> * New Crowdin translations by Github Action * fix: If the input type "Name" is selected, the label can't be changed from our default label "Your Name" (#10618) Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> * New Crowdin translations by Github Action * test: Create unit tests for react components in packages/ui/components/form/step (#10442) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> * feat: element call app added (#10585) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * New Crowdin translations by Github Action * New Crowdin translations by Github Action * fix: e2e test for rescheduling overlapping time (#10721) Co-authored-by: CarinaWolli <wollencarina@gmail.com> * feat: mailhog fixture (#10606) * feat: mailhog fixture * fix: nodemailer to dispatch emails with e2e env * fix: remove space from email subject * feat: fixture getFirstEventAsOwner * feat: assert email subjects * fix: and enable dynamic booking test (#10642) * fix and enable dynamic booking test * remove page pause --------- Co-authored-by: Alex van Andel <me@alexvanandel.com> * fix: Broken team events if a user with the same name exists (#10724) * fix: Broken team events if a user with the same name exists * Fix tests + fix usernameList optionality * Try to list calendars, if not continue (#10720) Co-authored-by: Omar López <zomars@me.com> * v3.1.9 * link to org settings (#10718) * feat: app paypal payment (#8797) Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> Co-authored-by: Omar López <zomars@me.com> * fix: RTL issues on booking pages + email confirmation (#10526) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: merge conflict * Fixing org slug (#10538) * fix: paypal build fixes * Fix avatar for org in Shell top (#10712) * feat: add range of dates for availability over-ride (#10462) * feat: add range of dates for availability over-ride * chore: changed range select to multiple select --------- Co-authored-by: Alex van Andel <me@alexvanandel.com> * fix: border issue for time slots (#10577) Co-authored-by: Raghul D <v-raghuld@microsoft.com> * style: Fix text wrapping issue in button (#10725) Co-authored-by: Omar López <zomars@me.com> * New Crowdin translations by Github Action * fix: App Install Dropdown Sort Properly [CAL-2285] (#10672) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: link escaping in booking page (#10360) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * chore: fix refund i18n message (#10731) * chore: remove tailwind-scrollbar warning (#10523) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * New Crowdin translations by Github Action * chore: Simplified date overrides (#10728) * chore: Simplified date overrides * Fixed a test that had a date override that wasn't at midnight utc * Wrote test that showed a fixed Europe/Brussels * Lint fix * New Crowdin translations by Github Action * Fix offset time + fetching correct dates * Deal with awkward minute offsets * remove store overhead * Format H based on tz * Cleanup store logic * Cleanup * Remove comments * Remove comments * Remove yarn.lock * Dark mode & v-align text fixes * Move ButtonGroup to the left to prevent chevron from jumping * Shift based on timezone (non-hour) and have 15min granularity in hour display background color --------- Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Zain Gulbaz <zaingulbaz8@gmail.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Suyash Srivastava <suyashsrivastava5053@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Pradumn Kumar <pradumn@tealfeed.com> Co-authored-by: Raghul <123321540+Raghul18@users.noreply.github.com> Co-authored-by: Raghul D <v-raghuld@microsoft.com> Co-authored-by: ABDERRAHMANI IDRISSI HAMZA <97639117+idrissi-hamza@users.noreply.github.com> Co-authored-by: Nafees Nazik <84864519+G3root@users.noreply.github.com> Co-authored-by: Danila <daniil.demidovich@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

zomars · 2023-08-20T22:54:41Z

apps/web/playwright/fixtures/users.ts

+      for (const user of store.users) {
+        const emailMessages = await emails.search(user.email);
+        if (emailMessages && emailMessages.count > 0) {
+          emailMessages.items.forEach((item) => {
+            emailMessageIds.push(item.ID);
+          });
+        }
+      }
+      for (const id of emailMessageIds) {
+        await emails.deleteMessage(id);
+      }


@leog @shivamklr I think this is why I get so many errors running e2e locally on production builds.

Can we make this optional? Only check for mailhog if it's enabled. I spent quite a while figuring out why all my tests were failing locally. At least we should document and update the README with instructions.

Sure. I will take a look and update the users fixture.

feat: mailhog fixture

2b3e126

Merge branch 'main' into feat/mailhog-poc

ced94fb

zomars added the core area: core, team members only label Aug 4, 2023

shivamklr requested review from a team, emrysal, keithwillcode and zomars August 4, 2023 18:27

vercel bot deployed to Preview – api August 4, 2023 18:30 View deployment

vercel bot deployed to Preview – dev August 4, 2023 18:30 View deployment

vercel bot deployed to Preview – cal-demo August 4, 2023 18:31 View deployment

fix: nodemailer to dispatch emails with e2e env

70124cf

vercel bot deployed to Preview – dev August 4, 2023 18:57 View deployment

vercel bot deployed to Preview – api August 4, 2023 18:58 View deployment

vercel bot deployed to Preview – cal-demo August 4, 2023 19:01 View deployment

Merge branch 'main' into feat/mailhog-poc

200fb7d

vercel bot had a problem deploying to Preview – api August 7, 2023 18:18 Failure

vercel bot deployed to Preview – ui August 7, 2023 18:19 View deployment

vercel bot deployed to Preview – dev August 7, 2023 18:21 View deployment

vercel bot deployed to Preview – cal-demo August 7, 2023 18:21 View deployment

shivamklr mentioned this pull request Aug 7, 2023

feat: container init in app-store and embeds workflow #10637

Merged

1 task

Merge branch 'main' into feat/mailhog-poc

6c7e205

vercel bot deployed to Preview – ui August 8, 2023 08:38 View deployment

vercel bot deployed to Preview – dev August 8, 2023 08:38 View deployment

vercel bot deployed to Preview – cal-demo August 11, 2023 06:03 View deployment

shivamklr added 4 commits August 11, 2023 17:55

fix: remove space from email subject

d4f0bc8

feat: fixture getFirstEventAsOwner

8e63ab2

feat: assert email subjects

984b80e

Merge branch 'main' into feat/mailhog-poc

7bb9f7f

shivamklr requested review from a team and removed request for emrysal, keithwillcode and zomars August 11, 2023 12:51

shivamklr marked this pull request as ready for review August 11, 2023 12:51

shivamklr enabled auto-merge (squash) August 11, 2023 12:51

vercel bot deployed to Preview – ui August 11, 2023 12:52 View deployment

vercel bot deployed to Preview – api August 11, 2023 12:59 View deployment

vercel bot deployed to Preview – dev August 11, 2023 13:00 View deployment

vercel bot deployed to Preview – cal-demo August 11, 2023 13:01 View deployment

CarinaWolli mentioned this pull request Aug 11, 2023

fix: allow new booking to overlap old one when rescheduling #10424

Merged

2 tasks

leog suggested changes Aug 11, 2023

View reviewed changes

leog approved these changes Aug 11, 2023

View reviewed changes

Merge branch 'main' into feat/mailhog-poc

b9f6ea5

vercel bot deployed to Preview – api August 11, 2023 18:51 View deployment

vercel bot deployed to Preview – cal-demo August 11, 2023 18:55 View deployment

shivamklr merged commit afe180a into main Aug 11, 2023

shivamklr deleted the feat/mailhog-poc branch August 11, 2023 18:56

vercel bot deployed to Preview – dev August 11, 2023 18:58 View deployment

sean-brydon pushed a commit that referenced this pull request Aug 14, 2023

feat: mailhog fixture (#10606)

a0705a7

* feat: mailhog fixture * fix: nodemailer to dispatch emails with e2e env * fix: remove space from email subject * feat: fixture getFirstEventAsOwner * feat: assert email subjects

zomars reviewed Aug 20, 2023

View reviewed changes

zomars mentioned this pull request Aug 20, 2023

[CAL-2366] Running E2E locally yields ECONNREFUSED #10855

Closed

Conversation

shivamklr commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Uh oh!

vercel bot commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel bot commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Uh oh!

socket-security bot commented Aug 4, 2023

Uh oh!

alwaysmeticulous bot commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicktrn commented Aug 4, 2023

Uh oh!

leog left a comment

Choose a reason for hiding this comment

Uh oh!

nicktrn commented Aug 11, 2023

Uh oh!

leog left a comment

Choose a reason for hiding this comment

Uh oh!

zomars Aug 20, 2023

Choose a reason for hiding this comment

Uh oh!

shivamklr Aug 21, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shivamklr commented Aug 4, 2023 •

edited

Loading

vercel bot commented Aug 4, 2023 •

edited

Loading

github-actions bot commented Aug 4, 2023 •

edited

Loading

github-actions bot commented Aug 4, 2023 •

edited

Loading

deploysentinel bot commented Aug 4, 2023 •

edited

Loading

alwaysmeticulous bot commented Aug 4, 2023 •

edited

Loading