Skip to content

feat: container init in app-store and embeds workflow#10637

Merged
shivamklr merged 4 commits intocalcom:mainfrom
shivamklr:fix/mailhog-container
Aug 8, 2023
Merged

feat: container init in app-store and embeds workflow#10637
shivamklr merged 4 commits intocalcom:mainfrom
shivamklr:fix/mailhog-container

Conversation

@shivamklr
Copy link
Copy Markdown
Contributor

@shivamklr shivamklr commented Aug 7, 2023

What does this PR do?

Fixes an issue in #10606, that the mailhog fixture is trying to connect to the container.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 1:39pm

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 7, 2023

@shivamklr is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@shivamklr shivamklr marked this pull request as ready for review August 7, 2023 18:34
@shivamklr shivamklr requested a review from keithwillcode August 7, 2023 18:36
@shivamklr shivamklr added the core area: core, team members only label Aug 8, 2023
@shivamklr shivamklr enabled auto-merge (squash) August 8, 2023 10:01
@shivamklr shivamklr merged commit 428e330 into calcom:main Aug 8, 2023
@shivamklr shivamklr deleted the fix/mailhog-container branch August 8, 2023 13:47
@keithwillcode keithwillcode added the automated-tests area: unit tests, e2e tests, playwright label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-tests area: unit tests, e2e tests, playwright core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants