Skip to content

fix: border issue for time slots#10577

Merged
PeerRich merged 1 commit intocalcom:mainfrom
Raghul18:fix-time-slot-border-issue
Aug 12, 2023
Merged

fix: border issue for time slots#10577
PeerRich merged 1 commit intocalcom:mainfrom
Raghul18:fix-time-slot-border-issue

Conversation

@Raghul18
Copy link
Copy Markdown
Contributor

@Raghul18 Raghul18 commented Aug 3, 2023

What does this PR do?

Fixes #10561

cal_slot_hover_border

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 3, 2023

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 7:20pm

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work labels Aug 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 3, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 3, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Ninety-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 91.83 KB 245.92 KB 70.26% (🟢 -1.04%)
/500 88.81 KB 242.9 KB 69.40% (🟢 -0.38%)
/[user] 98.7 KB 252.8 KB 72.23% (🟢 -1.08%)
/[user]/[type] 398.12 KB 552.22 KB 157.78% (🟢 -1.18%)
/[user]/[type]/embed 398.15 KB 552.25 KB 157.78% (🟢 -1.17%)
/[user]/embed 98.73 KB 252.83 KB 72.24% (🟢 -1.08%)
/_error 28.32 KB 182.41 KB 52.12% (🟢 -4.95%)
/apps 269.98 KB 424.07 KB 121.16% (🟢 -5.73%)
/apps/[slug] 288.02 KB 442.11 KB 126.32% (🟢 -5.88%)
/apps/[slug]/[...pages] 613.75 KB 767.84 KB 219.38% (🟢 -1.09%)
/apps/[slug]/setup 89.17 KB 243.27 KB 69.50% (🟢 -1.05%)
/apps/categories 249.12 KB 403.21 KB 115.20% (🟢 -0.78%)
/apps/categories/[category] 253.19 KB 407.29 KB 116.37% (🟢 -5.79%)
/apps/installed/[category] 269.38 KB 423.47 KB 120.99% (🟢 -0.84%)
/auth/error 101.93 KB 256.02 KB 73.15% (🟢 -0.94%)
/auth/forgot-password 136.18 KB 290.28 KB 82.94% (🟢 -1.05%)
/auth/forgot-password/[id] 135.53 KB 289.62 KB 82.75% (🟢 -1.04%)
/auth/login 151.83 KB 305.93 KB 87.41% (🟢 -1.05%)
/auth/logout 90.28 KB 244.37 KB 69.82% (🟢 -1.04%)
/auth/saml-idp 83.19 KB 237.28 KB 67.80% (🟢 -0.39%)
/auth/setup 173.89 KB 327.99 KB 93.71% (🟢 -0.49%)
/auth/signin 83.27 KB 237.36 KB 67.82% (🟢 -0.38%)
/auth/sso/[provider] 83.33 KB 237.42 KB 67.83% (🟢 -0.37%)
/auth/sso/direct 83.23 KB 237.33 KB 67.81% (🟢 -0.38%)
/auth/verify 100.89 KB 254.98 KB 72.85% (🟢 -0.42%)
/auth/verify-email 88.65 KB 242.74 KB 69.36% (🟢 -0.39%)
/availability 254.65 KB 408.75 KB 116.79% (🟢 -0.79%)
/availability/[schedule] 351.49 KB 505.58 KB 144.45% (🟢 -0.68%)
/availability/troubleshoot 249.86 KB 403.95 KB 115.42% (🟢 -0.77%)
/booking/[uid] 322.15 KB 476.25 KB 136.07% (🟢 -1.10%)
/bookings/[status] 342.63 KB 496.72 KB 141.92% (🟢 -0.39%)
/d/[link]/[slug] 398.14 KB 552.23 KB 157.78% (🟢 -1.18%)
/event-types 593.65 KB 747.74 KB 213.64% (🟢 -1.08%)
/event-types/[type] 477.65 KB 631.74 KB 180.50% (🟢 -1.06%)
/getting-started/[[...step]] 402.55 KB 556.65 KB 159.04% (🟢 -0.44%)
/insights 469.18 KB 623.28 KB 178.08% (🟢 -0.82%)
/maintenance 83.4 KB 237.5 KB 67.86% (🟢 -0.38%)
/more 248.75 KB 402.85 KB 115.10% (🟢 -0.78%)
/org/[orgSlug] 228.14 KB 382.24 KB 109.21% (🟢 -1.07%)
/org/[orgSlug]/[user] 234.31 KB 388.41 KB 110.97% (🟢 -1.06%)
/org/[orgSlug]/[user]/[type] 398.28 KB 552.38 KB 157.82% (🟢 -1.18%)
/org/[orgSlug]/[user]/[type]/embed 398.31 KB 552.4 KB 157.83% (🟢 -1.18%)
/org/[orgSlug]/team/[slug] 228.15 KB 382.25 KB 109.21% (🟢 -1.06%)
/org/[orgSlug]/team/[slug]/[type] 398.17 KB 552.26 KB 157.79% (🟢 -1.18%)
/payment/[uid] 123.05 KB 277.14 KB 79.18% (🟢 -0.40%)
/settings/admin 254.61 KB 408.7 KB 116.77% (🟢 -0.90%)
/settings/admin/apps 266.95 KB 421.04 KB 120.30% (🟢 -0.94%)
/settings/admin/apps/[category] 266.93 KB 421.03 KB 120.29% (🟢 -0.94%)
/settings/admin/flags 258.11 KB 412.2 KB 117.77% (🟢 -0.91%)
/settings/admin/impersonation 254.88 KB 408.98 KB 116.85% (🟢 -0.90%)
/settings/admin/organizations 255.68 KB 409.77 KB 117.08% (🟢 -0.90%)
/settings/admin/users 256.66 KB 410.75 KB 117.36% (🟢 -0.90%)
/settings/admin/users/[id]/edit 344.45 KB 498.54 KB 142.44% (🟢 -1.45%)
/settings/admin/users/add 344.17 KB 498.26 KB 142.36% (🟢 -1.45%)
/settings/billing 254.77 KB 408.87 KB 116.82% (🟢 -0.89%)
/settings/developer/api-keys 259.29 KB 413.39 KB 118.11% (🟢 -0.90%)
/settings/developer/webhooks 258.8 KB 412.89 KB 117.97% (🟢 -0.92%)
/settings/developer/webhooks/[id] 260.15 KB 414.25 KB 118.36% (🟢 -0.89%)
/settings/developer/webhooks/new 260.03 KB 414.12 KB 118.32% (🟢 -0.91%)
/settings/my-account/appearance 274.58 KB 428.68 KB 122.48% (🟢 -0.90%)
/settings/my-account/calendars 261.11 KB 415.2 KB 118.63% (🟢 -0.91%)
/settings/my-account/conferencing 260.62 KB 414.71 KB 118.49% (🟢 -0.94%)
/settings/my-account/general 340.28 KB 494.37 KB 141.25% (🟢 -1.53%)
/settings/my-account/profile 381.33 KB 535.42 KB 152.98% (🟢 -0.90%)
/settings/organizations/[id]/about 170.22 KB 324.31 KB 92.66% (🟢 -0.44%)
/settings/organizations/[id]/add-teams 170.25 KB 324.35 KB 92.67% (🟢 -0.44%)
/settings/organizations/[id]/onboard-admins 170.27 KB 324.36 KB 92.67% (🟢 -0.44%)
/settings/organizations/[id]/set-password 170.21 KB 324.31 KB 92.66% (🟢 -0.44%)
/settings/organizations/appearance 261.47 KB 415.57 KB 118.73% (🟢 -0.89%)
/settings/organizations/billing 254.62 KB 408.71 KB 116.77% (🟢 -0.89%)
/settings/organizations/general 335.24 KB 489.33 KB 139.81% (🟢 -0.90%)
/settings/organizations/members 284.38 KB 438.47 KB 125.28% (🟢 -0.90%)
/settings/organizations/new 170.2 KB 324.29 KB 92.65% (🟢 -0.45%)
/settings/organizations/profile 376.07 KB 530.17 KB 151.48% (🟢 -0.90%)
/settings/security/impersonation 257.27 KB 411.36 KB 117.53% (🟢 -0.90%)
/settings/security/password 269.01 KB 423.1 KB 120.89% (🟢 -0.90%)
/settings/security/sso 264.05 KB 418.14 KB 119.47% (🟢 -0.90%)
/settings/security/two-factor-auth 259.88 KB 413.98 KB 118.28% (🟢 -0.90%)
/settings/teams 254.37 KB 408.47 KB 116.70% (🟢 -0.89%)
/settings/teams/[id]/appearance 264.07 KB 418.16 KB 119.48% (🟢 -0.90%)
/settings/teams/[id]/billing 254.62 KB 408.71 KB 116.78% (🟢 -0.90%)
/settings/teams/[id]/members 376.07 KB 530.16 KB 151.47% (🟢 -1.04%)
/settings/teams/[id]/onboard-members 167.26 KB 321.35 KB 91.82% (🟢 -0.45%)
/settings/teams/[id]/profile 445.31 KB 599.41 KB 171.26% (🟢 -1.09%)
/settings/teams/[id]/sso 264.14 KB 418.24 KB 119.50% (🟢 -0.90%)
/settings/teams/new 190.7 KB 344.79 KB 98.51% (🟢 -0.45%)
/signup 147.77 KB 301.86 KB 86.25% (🟢 -1.06%)
/team/[slug] 228.1 KB 382.2 KB 109.20% (🟢 -1.07%)
/team/[slug]/[type] 398.13 KB 552.23 KB 157.78% (🟢 -1.18%)
/team/[slug]/[type]/embed 398.16 KB 552.26 KB 157.79% (🟢 -1.18%)
/team/[slug]/embed 228.15 KB 382.24 KB 109.21% (🟢 -1.07%)
/teams 248.9 KB 402.99 KB 115.14% (🟢 -0.78%)
/video/[uid] 239.6 KB 393.7 KB 112.48% (🟢 -0.38%)
/video/meeting-ended/[uid] 96.99 KB 251.08 KB 71.74% (🟢 -1.05%)
/video/meeting-not-started/[uid] 96.63 KB 250.72 KB 71.64% (🟢 -1.05%)
/video/no-meeting-found 88.9 KB 243 KB 69.43% (🟢 -1.05%)
/workflows 283.88 KB 437.98 KB 125.14% (🟢 -0.83%)
/workflows/[workflow] 396.17 KB 550.26 KB 157.22% (🟢 -0.79%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich PeerRich merged commit 7603ea6 into calcom:main Aug 12, 2023
sean-brydon pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Raghul D <v-raghuld@microsoft.com>
sean-brydon added a commit that referenced this pull request Aug 18, 2023
* Init + get timezone + offset data agh

* Add 12/24h mode - style correctly

* User users timezone + working hours. Still some stuff to figure out

* Multiple working hours

* move calc to once per day

* Demo with two users and differnt timezones

* availabillity control tab via search params

* WIP hover overlay

* THIS WORKS ISH

* fix: multiple duration getSchedule calls [CAL-2336] (#10709)

Co-authored-by: Omar López <zomars@me.com>

* New Crowdin translations by Github Action

* fix: If the input type "Name" is selected, the label can't be changed from our default label "Your Name" (#10618)

Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>

* New Crowdin translations by Github Action

* test: Create unit tests for react components in packages/ui/components/form/step (#10442)

Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>
Co-authored-by: Keith Williams <keithwillcode@gmail.com>

* feat: element call app added (#10585)

Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>

* New Crowdin translations by Github Action

* New Crowdin translations by Github Action

* fix: e2e test for rescheduling overlapping time (#10721)

Co-authored-by: CarinaWolli <wollencarina@gmail.com>

* feat: mailhog fixture (#10606)

* feat: mailhog fixture

* fix: nodemailer to dispatch emails with e2e env

* fix: remove space from email subject

* feat: fixture getFirstEventAsOwner

* feat: assert email subjects

* fix: and enable dynamic booking test (#10642)

* fix and enable dynamic booking test

* remove page pause

---------

Co-authored-by: Alex van Andel <me@alexvanandel.com>

* fix: Broken team events if a user with the same name exists (#10724)

* fix: Broken team events if a user with the same name exists

* Fix tests + fix usernameList optionality

* Try to list calendars, if not continue (#10720)

Co-authored-by: Omar López <zomars@me.com>

* v3.1.9

* link to org settings (#10718)

* feat: app paypal payment (#8797)

Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Co-authored-by: Omar López <zomars@me.com>

* fix: RTL issues on booking pages + email confirmation (#10526)

Co-authored-by: Peer Richelsen <peeroke@gmail.com>

* fix: merge conflict

* Fixing org slug (#10538)

* fix: paypal build fixes

* Fix avatar for org in Shell top (#10712)

* feat: add range of dates for availability over-ride (#10462)

* feat: add range of dates for availability over-ride

* chore: changed range select to multiple select

---------

Co-authored-by: Alex van Andel <me@alexvanandel.com>

* fix: border issue for time slots (#10577)

Co-authored-by: Raghul D <v-raghuld@microsoft.com>

* style: Fix text wrapping issue in button (#10725)

Co-authored-by: Omar López <zomars@me.com>

* New Crowdin translations by Github Action

* fix: App Install Dropdown Sort Properly [CAL-2285] (#10672)

Co-authored-by: Peer Richelsen <peeroke@gmail.com>

* fix: link escaping in booking page (#10360)

Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>

* chore: fix refund i18n message (#10731)

* chore: remove tailwind-scrollbar warning (#10523)

Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

* New Crowdin translations by Github Action

* chore: Simplified date overrides (#10728)

* chore: Simplified date overrides

* Fixed a test that had a date override that wasn't at midnight utc

* Wrote test that showed a fixed Europe/Brussels

* Lint fix

* New Crowdin translations by Github Action

* Fix offset time + fetching correct dates

* Deal with awkward minute offsets

* remove store overhead

* Format H based on tz

* Cleanup store logic

* Cleanup

* Remove comments

* Remove comments

* Remove yarn.lock

* Dark mode & v-align text fixes

* Move ButtonGroup to the left to prevent chevron from jumping

* Shift based on timezone (non-hour) and have 15min granularity in hour display background color

---------

Co-authored-by: Leo Giovanetti <hello@leog.me>
Co-authored-by: Omar López <zomars@me.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Zain Gulbaz <zaingulbaz8@gmail.com>
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com>
Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>
Co-authored-by: Keith Williams <keithwillcode@gmail.com>
Co-authored-by: Suyash Srivastava <suyashsrivastava5053@gmail.com>
Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com>
Co-authored-by: alannnc <alannnc@gmail.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
Co-authored-by: Pradumn Kumar <pradumn@tealfeed.com>
Co-authored-by: Raghul <123321540+Raghul18@users.noreply.github.com>
Co-authored-by: Raghul D <v-raghuld@microsoft.com>
Co-authored-by: ABDERRAHMANI IDRISSI HAMZA <97639117+idrissi-hamza@users.noreply.github.com>
Co-authored-by: Nafees Nazik <84864519+G3root@users.noreply.github.com>
Co-authored-by: Danila <daniil.demidovich@gmail.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2314] booking page: remove border of hover

3 participants