test: Create unit tests for react components in packages/ui/components/form/step by gitstart-calcom · Pull Request #10442 · calcom/cal.com

gitstart-calcom · 2023-07-28T12:54:04Z

Demo

Run

yarn test step

vercel · 2023-07-28T12:54:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 8, 2023 0:07am
cal	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 8, 2023 0:07am
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 8, 2023 0:07am
dev	❌ Failed (Inspect)			Aug 8, 2023 0:07am
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 8, 2023 0:07am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
qa	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2023 0:07am

github-actions · 2023-07-28T12:54:19Z

Thank you for following the naming conventions! 🙏

github-actions · 2023-07-28T13:02:19Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-07-28T13:03:50Z

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/08/2023 12:11:09pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ea202ea

Started: 08/08/2023 12:09:04pm UTC

⚠️ Flakes

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user can add multiple organizer address Retry 1 • Initial Attempt	1.68% (5) 5 / 298 runs failed over last 7 days	1.68% (5) 5 / 298 runs flaked over last 7 days

📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Managed Event Types tests Can create managed event type Retry 1 • Initial Attempt	1% (3) 3 / 300 runs failed over last 7 days	12% (36) 36 / 300 runs flaked over last 7 days

📄 packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields Retry 1 • Initial Attempt	1% (3) 3 / 299 runs failed over last 7 days	9.36% (28) 28 / 299 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	2.68% (8) 8 / 298 runs failed over last 7 days	97.32% (290) 290 / 298 runs flaked over last 7 days

View Detailed Build Results

alwaysmeticulous · 2023-07-28T13:08:35Z

🤖 Meticulous spotted visual differences in 71 of 198 screens tested: view and approve differences detected.

_{Last updated for commit f502556. This comment will update as new commits are pushed.}

hariombalhara · 2023-07-31T06:50:49Z

packages/ui/components/form/step/steps.test.tsx

+    const { getByTestId, getByText } = render(<Steps {...Props} />);
+
+    for (let i = 0; i < Props.maxSteps; i++) {
+      const step = getByTestId(`step-indicator-${i}`);


getByTestId gets by data-testid attribute only. So, it would always have toHaveAttribute("data-testid") assertion passing.
I don't think we need toHaveAttribute assertion, instead we should check that the steps till current step are clickable. There are 2 things in there

Presence of cursor-pointer class. I know that we shouldn't test implementation details but this class is something that must always be present as long as we are using tailwind

Clicking every step till current step and checking that navigateToStep is being called.

Negative test for above 2 scenarios as well that they don't work for steps after the current step

hariombalhara · 2023-07-31T06:53:01Z

packages/ui/components/form/step/steps.test.tsx

+    fireEvent.click(stepIndicators);
+    expect(mockNavigateToStep).toHaveBeenCalledTimes(1);
+
+    CURRENT_STEP = CURRENT_STEP + 1;


A test shouldn't modify external variable.

hariombalhara

Thanks @gitstart. Left some comments

gitstart-calcom · 2023-08-03T20:06:49Z

Hello @hariombalhara
The changes have been made, can you review them, please?

hariombalhara

Thanks @gitstart-calcom 🙏 Looks good now!!

…s/form/step (#10442) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com>

* Init + get timezone + offset data agh * Add 12/24h mode - style correctly * User users timezone + working hours. Still some stuff to figure out * Multiple working hours * move calc to once per day * Demo with two users and differnt timezones * availabillity control tab via search params * WIP hover overlay * THIS WORKS ISH * fix: multiple duration getSchedule calls [CAL-2336] (#10709) Co-authored-by: Omar López <zomars@me.com> * New Crowdin translations by Github Action * fix: If the input type "Name" is selected, the label can't be changed from our default label "Your Name" (#10618) Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> * New Crowdin translations by Github Action * test: Create unit tests for react components in packages/ui/components/form/step (#10442) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> * feat: element call app added (#10585) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * New Crowdin translations by Github Action * New Crowdin translations by Github Action * fix: e2e test for rescheduling overlapping time (#10721) Co-authored-by: CarinaWolli <wollencarina@gmail.com> * feat: mailhog fixture (#10606) * feat: mailhog fixture * fix: nodemailer to dispatch emails with e2e env * fix: remove space from email subject * feat: fixture getFirstEventAsOwner * feat: assert email subjects * fix: and enable dynamic booking test (#10642) * fix and enable dynamic booking test * remove page pause --------- Co-authored-by: Alex van Andel <me@alexvanandel.com> * fix: Broken team events if a user with the same name exists (#10724) * fix: Broken team events if a user with the same name exists * Fix tests + fix usernameList optionality * Try to list calendars, if not continue (#10720) Co-authored-by: Omar López <zomars@me.com> * v3.1.9 * link to org settings (#10718) * feat: app paypal payment (#8797) Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> Co-authored-by: Omar López <zomars@me.com> * fix: RTL issues on booking pages + email confirmation (#10526) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: merge conflict * Fixing org slug (#10538) * fix: paypal build fixes * Fix avatar for org in Shell top (#10712) * feat: add range of dates for availability over-ride (#10462) * feat: add range of dates for availability over-ride * chore: changed range select to multiple select --------- Co-authored-by: Alex van Andel <me@alexvanandel.com> * fix: border issue for time slots (#10577) Co-authored-by: Raghul D <v-raghuld@microsoft.com> * style: Fix text wrapping issue in button (#10725) Co-authored-by: Omar López <zomars@me.com> * New Crowdin translations by Github Action * fix: App Install Dropdown Sort Properly [CAL-2285] (#10672) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: link escaping in booking page (#10360) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * chore: fix refund i18n message (#10731) * chore: remove tailwind-scrollbar warning (#10523) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * New Crowdin translations by Github Action * chore: Simplified date overrides (#10728) * chore: Simplified date overrides * Fixed a test that had a date override that wasn't at midnight utc * Wrote test that showed a fixed Europe/Brussels * Lint fix * New Crowdin translations by Github Action * Fix offset time + fetching correct dates * Deal with awkward minute offsets * remove store overhead * Format H based on tz * Cleanup store logic * Cleanup * Remove comments * Remove comments * Remove yarn.lock * Dark mode & v-align text fixes * Move ButtonGroup to the left to prevent chevron from jumping * Shift based on timezone (non-hour) and have 15min granularity in hour display background color --------- Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Zain Gulbaz <zaingulbaz8@gmail.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Suyash Srivastava <suyashsrivastava5053@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Pradumn Kumar <pradumn@tealfeed.com> Co-authored-by: Raghul <123321540+Raghul18@users.noreply.github.com> Co-authored-by: Raghul D <v-raghuld@microsoft.com> Co-authored-by: ABDERRAHMANI IDRISSI HAMZA <97639117+idrissi-hamza@users.noreply.github.com> Co-authored-by: Nafees Nazik <84864519+G3root@users.noreply.github.com> Co-authored-by: Danila <daniil.demidovich@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

Create RTL tests for Step component

37d541b

zomars added the core area: core, team members only label Jul 28, 2023

vercel bot deployed to Preview – ui July 28, 2023 12:58 View deployment

vercel bot deployed to Preview – cal-demo July 28, 2023 12:59 View deployment

vercel bot deployed to Preview – api July 28, 2023 13:01 View deployment

vercel bot deployed to Preview – dev July 28, 2023 13:08 View deployment

gitstart-calcom requested a review from sean-brydon July 28, 2023 13:12

gitstart-calcom marked this pull request as ready for review July 28, 2023 13:12

gitstart-calcom requested review from a team and keithwillcode July 28, 2023 13:13

Merge branch 'main' into test-step

8e3f159

vercel bot deployed to Preview – ui July 28, 2023 18:07 View deployment

vercel bot deployed to Preview – dev July 28, 2023 18:08 View deployment

vercel bot deployed to Preview – cal-demo July 28, 2023 18:09 View deployment

vercel bot deployed to Preview – api July 28, 2023 18:09 View deployment

Merge branch 'main' into test-step

84f07dd

vercel bot deployed to Preview – api July 31, 2023 06:20 View deployment

vercel bot deployed to Preview – cal-demo July 31, 2023 06:21 View deployment

vercel bot deployed to Preview – dev July 31, 2023 06:22 View deployment

hariombalhara reviewed Jul 31, 2023

View reviewed changes

hariombalhara requested changes Jul 31, 2023

View reviewed changes

keithwillcode added Low priority Created by Linear-GitHub Sync automated-tests area: unit tests, e2e tests, playwright labels Jul 31, 2023

gitstart-calcom mentioned this pull request Jul 31, 2023

Create unit tests for components #10406

Closed

28 tasks

vercel bot deployed to Preview – cal-demo August 3, 2023 20:00 View deployment

vercel bot deployed to Preview – dev August 3, 2023 20:01 View deployment

Merge branch 'main' into test-step

9f00501

gitstart-calcom requested a review from hariombalhara August 4, 2023 03:27

vercel bot deployed to Preview – ui August 4, 2023 03:31 View deployment

vercel bot deployed to Preview – dev August 4, 2023 03:32 View deployment

vercel bot deployed to Preview – api August 4, 2023 03:32 View deployment

vercel bot deployed to Preview – cal-demo August 4, 2023 03:35 View deployment

Merge branch 'main' into test-step

62123a7

vercel bot deployed to Preview – ui August 5, 2023 22:22 View deployment

vercel bot deployed to Preview – api August 5, 2023 22:24 View deployment

vercel bot deployed to Preview – dev August 5, 2023 22:24 View deployment

vercel bot deployed to Preview – cal-demo August 5, 2023 22:25 View deployment

Merge branch 'main' into test-step

f502556

vercel bot deployed to Preview – ui August 8, 2023 07:02 View deployment

keithwillcode requested a review from a team August 8, 2023 07:03

vercel bot deployed to Preview – api August 8, 2023 07:04 View deployment

vercel bot deployed to Preview – cal-demo August 8, 2023 07:05 View deployment

vercel bot deployed to Preview – dev August 8, 2023 07:07 View deployment

Merge branch 'main' into test-step

ea202ea

vercel bot had a problem deploying to Preview – dev August 8, 2023 12:04 Failure

vercel bot deployed to Preview – ui August 8, 2023 12:04 View deployment

vercel bot deployed to Preview – api August 8, 2023 12:06 View deployment

vercel bot deployed to Preview – cal-demo August 8, 2023 12:07 View deployment

hariombalhara approved these changes Aug 11, 2023

View reviewed changes

hariombalhara merged commit cfe7ea4 into main Aug 11, 2023

hariombalhara deleted the test-step branch August 11, 2023 06:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Create unit tests for react components in packages/ui/components/form/step#10442

test: Create unit tests for react components in packages/ui/components/form/step#10442
hariombalhara merged 9 commits intomainfrom
test-step

gitstart-calcom commented Jul 28, 2023 •

edited

Loading

Uh oh!

vercel bot commented Jul 28, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 28, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jul 28, 2023 •

edited

Loading

Uh oh!

deploysentinel bot commented Jul 28, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Uh oh!

alwaysmeticulous bot commented Jul 28, 2023 •

edited

Loading

Uh oh!

hariombalhara Jul 31, 2023 •

edited

Loading

Uh oh!

hariombalhara Jul 31, 2023

Uh oh!

hariombalhara left a comment

Uh oh!

gitstart-calcom commented Aug 3, 2023

Uh oh!

hariombalhara left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gitstart-calcom commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo

Uh oh!

vercel bot commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel bot commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Uh oh!

alwaysmeticulous bot commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

gitstart-calcom commented Aug 3, 2023

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gitstart-calcom commented Jul 28, 2023 •

edited

Loading

vercel bot commented Jul 28, 2023 •

edited

Loading

github-actions bot commented Jul 28, 2023 •

edited

Loading

github-actions bot commented Jul 28, 2023 •

edited

Loading

deploysentinel bot commented Jul 28, 2023 •

edited

Loading

alwaysmeticulous bot commented Jul 28, 2023 •

edited

Loading

hariombalhara Jul 31, 2023 •

edited

Loading