fix: and enable dynamic booking test by alannnc · Pull Request #10642 · calcom/cal.com

alannnc · 2023-08-08T06:46:08Z

What does this PR do?

Enabling dynamic booking test to run again with new booker.
Fix getBookingForReschedule()

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works

vercel · 2023-08-08T06:46:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 11, 2023 7:06pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 11, 2023 7:06pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 11, 2023 7:06pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 11, 2023 7:06pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Aug 11, 2023 7:06pm
qa	⬜️ Ignored (Inspect)	Visit Preview		Aug 11, 2023 7:06pm

github-actions · 2023-08-08T06:46:21Z

Thank you for following the naming conventions! 🙏

packages/features/bookings/lib/get-booking.ts

alannnc · 2023-08-08T06:48:16Z

packages/features/bookings/lib/get-booking.ts


 export const getBookingForReschedule = async (uid: string) => {
-  let eventTypeId: number | null = null;
-  let rescheduleUid: string | null = null;


rescheduleUid no longer needed.

alwaysmeticulous · 2023-08-08T06:50:04Z

🤖 Meticulous spotted visual differences in 19 of 245 screens tested: view and approve differences detected.

_{Last updated for commit 36ca2dc. This comment will update as new commits are pushed.}

github-actions · 2023-08-08T06:57:13Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-08-08T06:58:08Z

Current Playwright Test Results Summary

✅ 116 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/11/2023 07:05:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 36ca2dc

Started: 08/11/2023 07:04:01pm UTC

⚠️ Flakes

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Paid booking should be able to be rescheduled Retry 1 • Initial Attempt	7.57% (24) 24 / 317 runs failed over last 7 days	6.94% (22) 22 / 317 runs flaked over last 7 days

📄 apps/web/playwright/reschedule.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Reschedule Tests Should display request reschedule send on bookings/cancelled Retry 1 • Initial Attempt	0% (0) 0 / 321 runs failed over last 7 days	1.25% (4) 4 / 321 runs flaked over last 7 days
Reschedule Tests Paid rescheduling should go to success page Retry 1 • Initial Attempt	0% (0) 0 / 309 runs failed over last 7 days	1.29% (4) 4 / 309 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	5.08% (16) 16 / 315 runs failed over last 7 days	94.92% (299) 299 / 315 runs flaked over last 7 days

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 1 • Initial Attempt	1.29% (4) 4 / 309 runs failed over last 7 days	0.32% (1) 1 / 309 run flaked over last 7 days
Routing Forms Seeded Routing Form Routing Link should validate fields Retry 1 • Initial Attempt	0.97% (3) 3 / 309 runs failed over last 7 days	6.47% (20) 20 / 309 runs flaked over last 7 days

📄 packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 1 • Initial Attempt	0.96% (3) 3 / 311 runs failed over last 7 days	7.07% (22) 22 / 311 runs flaked over last 7 days

View Detailed Build Results

…into fix-dynamic-booking-test

emrysal

Nice 👍

…into fix-dynamic-booking-test

alannnc · 2023-08-11T19:02:28Z

Left a comment. Also, reschedule tests are failing, it might be related.

@hariombalhara Undo some changes as seem they were necesary. Tests should be fine now.

Changes were addressed

* fix and enable dynamic booking test * remove page pause --------- Co-authored-by: Alex van Andel <me@alexvanandel.com>

* Init + get timezone + offset data agh * Add 12/24h mode - style correctly * User users timezone + working hours. Still some stuff to figure out * Multiple working hours * move calc to once per day * Demo with two users and differnt timezones * availabillity control tab via search params * WIP hover overlay * THIS WORKS ISH * fix: multiple duration getSchedule calls [CAL-2336] (#10709) Co-authored-by: Omar López <zomars@me.com> * New Crowdin translations by Github Action * fix: If the input type "Name" is selected, the label can't be changed from our default label "Your Name" (#10618) Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> * New Crowdin translations by Github Action * test: Create unit tests for react components in packages/ui/components/form/step (#10442) Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> * feat: element call app added (#10585) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * New Crowdin translations by Github Action * New Crowdin translations by Github Action * fix: e2e test for rescheduling overlapping time (#10721) Co-authored-by: CarinaWolli <wollencarina@gmail.com> * feat: mailhog fixture (#10606) * feat: mailhog fixture * fix: nodemailer to dispatch emails with e2e env * fix: remove space from email subject * feat: fixture getFirstEventAsOwner * feat: assert email subjects * fix: and enable dynamic booking test (#10642) * fix and enable dynamic booking test * remove page pause --------- Co-authored-by: Alex van Andel <me@alexvanandel.com> * fix: Broken team events if a user with the same name exists (#10724) * fix: Broken team events if a user with the same name exists * Fix tests + fix usernameList optionality * Try to list calendars, if not continue (#10720) Co-authored-by: Omar López <zomars@me.com> * v3.1.9 * link to org settings (#10718) * feat: app paypal payment (#8797) Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> Co-authored-by: Omar López <zomars@me.com> * fix: RTL issues on booking pages + email confirmation (#10526) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: merge conflict * Fixing org slug (#10538) * fix: paypal build fixes * Fix avatar for org in Shell top (#10712) * feat: add range of dates for availability over-ride (#10462) * feat: add range of dates for availability over-ride * chore: changed range select to multiple select --------- Co-authored-by: Alex van Andel <me@alexvanandel.com> * fix: border issue for time slots (#10577) Co-authored-by: Raghul D <v-raghuld@microsoft.com> * style: Fix text wrapping issue in button (#10725) Co-authored-by: Omar López <zomars@me.com> * New Crowdin translations by Github Action * fix: App Install Dropdown Sort Properly [CAL-2285] (#10672) Co-authored-by: Peer Richelsen <peeroke@gmail.com> * fix: link escaping in booking page (#10360) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * chore: fix refund i18n message (#10731) * chore: remove tailwind-scrollbar warning (#10523) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> * New Crowdin translations by Github Action * chore: Simplified date overrides (#10728) * chore: Simplified date overrides * Fixed a test that had a date override that wasn't at midnight utc * Wrote test that showed a fixed Europe/Brussels * Lint fix * New Crowdin translations by Github Action * Fix offset time + fetching correct dates * Deal with awkward minute offsets * remove store overhead * Format H based on tz * Cleanup store logic * Cleanup * Remove comments * Remove comments * Remove yarn.lock * Dark mode & v-align text fixes * Move ButtonGroup to the left to prevent chevron from jumping * Shift based on timezone (non-hour) and have 15min granularity in hour display background color --------- Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: Omar López <zomars@me.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Zain Gulbaz <zaingulbaz8@gmail.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: GitStart-Cal.com <121884634+gitstart-calcom@users.noreply.github.com> Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Suyash Srivastava <suyashsrivastava5053@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Shivam Kalra <shivamkalra98@gmail.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Pradumn Kumar <pradumn@tealfeed.com> Co-authored-by: Raghul <123321540+Raghul18@users.noreply.github.com> Co-authored-by: Raghul D <v-raghuld@microsoft.com> Co-authored-by: ABDERRAHMANI IDRISSI HAMZA <97639117+idrissi-hamza@users.noreply.github.com> Co-authored-by: Nafees Nazik <84864519+G3root@users.noreply.github.com> Co-authored-by: Danila <daniil.demidovich@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

fix and enable dynamic booking test

5e50a3f

zomars added the core area: core, team members only label Aug 8, 2023

alannnc commented Aug 8, 2023

View reviewed changes

packages/features/bookings/lib/get-booking.ts Show resolved Hide resolved

vercel bot deployed to Preview – ui August 8, 2023 06:47 View deployment

alannnc commented Aug 8, 2023

View reviewed changes

Merge branch 'main' into fix-dynamic-booking-test

c5fd41b

alannnc requested a review from a team August 8, 2023 06:50

vercel bot deployed to Preview – ui August 8, 2023 06:53 View deployment

vercel bot deployed to Preview – api August 8, 2023 06:55 View deployment

vercel bot deployed to Preview – dev August 8, 2023 06:56 View deployment

vercel bot deployed to Preview – cal-demo August 8, 2023 06:59 View deployment

alannnc added 2 commits August 7, 2023 23:59

remove page pause

9deeff4

Merge branch 'fix-dynamic-booking-test' of github.com:calcom/cal.com …

2d66b2e

…into fix-dynamic-booking-test

vercel bot deployed to Preview – dev August 8, 2023 07:04 View deployment

vercel bot deployed to Preview – api August 8, 2023 07:05 View deployment

vercel bot deployed to Preview – cal-demo August 8, 2023 07:05 View deployment

Merge branch 'main' into fix-dynamic-booking-test

b364619

emrysal enabled auto-merge (squash) August 8, 2023 12:54

emrysal previously approved these changes Aug 8, 2023

View reviewed changes

vercel bot deployed to Preview – api August 8, 2023 12:59 View deployment

vercel bot deployed to Preview – cal-demo August 8, 2023 13:00 View deployment

vercel bot deployed to Preview – ui August 8, 2023 13:00 View deployment

vercel bot deployed to Preview – dev August 8, 2023 13:09 View deployment

alannnc added 2 commits August 8, 2023 12:44

Merge with main

e6d31d0

Merge branch 'fix-dynamic-booking-test' of github.com:calcom/cal.com …

3ac06e9

…into fix-dynamic-booking-test

Merge branch 'main' into fix-dynamic-booking-test

7a7f278

emrysal requested a review from hariombalhara August 10, 2023 17:20

vercel bot deployed to Preview – ui August 10, 2023 17:32 View deployment

vercel bot deployed to Preview – cal-demo August 10, 2023 17:32 View deployment

vercel bot deployed to Preview – api August 10, 2023 17:33 View deployment

vercel bot deployed to Preview – dev August 10, 2023 17:35 View deployment

Merge branch 'main' into fix-dynamic-booking-test

4dee324

vercel bot deployed to Preview – ui August 11, 2023 01:02 View deployment

vercel bot deployed to Preview – api August 11, 2023 01:04 View deployment

vercel bot deployed to Preview – dev August 11, 2023 01:05 View deployment

vercel bot deployed to Preview – cal-demo August 11, 2023 01:05 View deployment

alannnc added 3 commits August 11, 2023 11:44

Undo code change and improve comment

9426e63

Merge branch 'main' into fix-dynamic-booking-test

63c97f2

Merge branch 'main' into fix-dynamic-booking-test

8ba9355

vercel bot deployed to Preview – ui August 11, 2023 18:52 View deployment

vercel bot deployed to Preview – dev August 11, 2023 18:54 View deployment

vercel bot deployed to Preview – api August 11, 2023 18:54 View deployment

Merge branch 'main' into fix-dynamic-booking-test

36ca2dc

vercel bot deployed to Preview – ui August 11, 2023 19:00 View deployment

vercel bot deployed to Preview – api August 11, 2023 19:04 View deployment

vercel bot deployed to Preview – dev August 11, 2023 19:05 View deployment

vercel bot deployed to Preview – cal-demo August 11, 2023 19:06 View deployment

alannnc requested a review from emrysal August 11, 2023 19:07

zomars approved these changes Aug 11, 2023

View reviewed changes

emrysal merged commit 4d5697f into main Aug 11, 2023

emrysal deleted the fix-dynamic-booking-test branch August 11, 2023 20:33

sean-brydon pushed a commit that referenced this pull request Aug 14, 2023

fix: and enable dynamic booking test (#10642)

98a14fb

* fix and enable dynamic booking test * remove page pause --------- Co-authored-by: Alex van Andel <me@alexvanandel.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: and enable dynamic booking test#10642

fix: and enable dynamic booking test#10642
emrysal merged 19 commits intomainfrom
fix-dynamic-booking-test

alannnc commented Aug 8, 2023

Uh oh!

vercel bot commented Aug 8, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Aug 8, 2023 •

edited

Loading

Uh oh!

Uh oh!

alannnc Aug 8, 2023

Uh oh!

alwaysmeticulous bot commented Aug 8, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Aug 8, 2023 •

edited

Loading

Uh oh!

deploysentinel bot commented Aug 8, 2023 •

edited

Loading

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Uh oh!

emrysal left a comment

Uh oh!

alannnc commented Aug 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alannnc commented Aug 8, 2023

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

Checklist

Uh oh!

vercel bot commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alannnc Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

alwaysmeticulous bot commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel bot commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Uh oh!

emrysal left a comment

Choose a reason for hiding this comment

Uh oh!

alannnc commented Aug 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel bot commented Aug 8, 2023 •

edited

Loading

github-actions bot commented Aug 8, 2023 •

edited

Loading

alwaysmeticulous bot commented Aug 8, 2023 •

edited

Loading

github-actions bot commented Aug 8, 2023 •

edited

Loading

deploysentinel bot commented Aug 8, 2023 •

edited

Loading