Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 30 of 119 screens tested: view and approve differences detected. Last updated for commit 3dd88ee. This comment will update as new commits are pushed. |
|
@keithwillcode For the reference I am using these exact .env variables locally. And the mailhog service is able to capture the emails. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 115 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/03/2023 01:31:31pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 3dd88ee Started: 08/03/2023 01:29:17pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.35% (1)1 / 283 runfailed over last 7 days |
24.03% (68)68 / 283 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.74% (5)5 / 287 runsfailed over last 7 days |
96.17% (276)276 / 287 runsflaked over last 7 days |
keithwillcode
left a comment
There was a problem hiding this comment.
We should probably use these same settings for the other e2e jobs as well, right?
|
Just a quick heads up that I plan to open an RFC today re fully parallel e2e email testing. Does not require messing around with mailhog, auth, new env vars, etc. Did some prototyping and think this could work well. |
zomars
left a comment
There was a problem hiding this comment.
Do we need to do this in e2e-appstore and embed as well?
|
@zomars If they use the same endpoints/components then no. |
|
@zomars Just to clear things up. I will be doing this for the core e2e first. Once we cover that, we can move the changes so it covers all the e2e. |
What does this PR do?
Enable Mailhog for e2e tests. These changes should be non-breaking and should only start the mailhog container for future commit usage.
This PR should be merged prior to the PR to test PoC for mailhog with the Github workflows.
Requirement/Documentation
Setup the following github secrets
Type of change