Skip to content

chore: mailhog#10521

Merged
keithwillcode merged 4 commits intomainfrom
feat/mailhog-workflow
Aug 3, 2023
Merged

chore: mailhog#10521
keithwillcode merged 4 commits intomainfrom
feat/mailhog-workflow

Conversation

@shivamklr
Copy link
Copy Markdown
Contributor

@shivamklr shivamklr commented Aug 2, 2023

What does this PR do?

Enable Mailhog for e2e tests. These changes should be non-breaking and should only start the mailhog container for future commit usage.
This PR should be merged prior to the PR to test PoC for mailhog with the Github workflows.

Requirement/Documentation

Setup the following github secrets

  • EMAIL_SERVER_HOST
  • EMAIL_SERVER_PORT
  • EMAIL_SERVER_USER
  • EMAIL_SERVER_PASSWORD

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

@shivamklr shivamklr requested a review from keithwillcode August 2, 2023 08:16
@vercel
Copy link
Copy Markdown

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 1:28pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 1:28pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 1:28pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 1:28pm
qa ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 1:28pm
ui ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 1:28pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 2, 2023

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous bot commented Aug 2, 2023

🤖 Meticulous spotted visual differences in 30 of 119 screens tested: view and approve differences detected.

Last updated for commit 3dd88ee. This comment will update as new commits are pushed.

@shivamklr
Copy link
Copy Markdown
Contributor Author

@keithwillcode For the reference I am using these exact .env variables locally. And the mailhog service is able to capture the emails.

EMAIL_SERVER_HOST='localhost'
EMAIL_SERVER_PORT=1025
EMAIL_SERVER_USER='<office365_emailAddress>'
EMAIL_SERVER_PASSWORD='<office365_password>'

@shivamklr shivamklr marked this pull request as ready for review August 2, 2023 08:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 2, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Aug 2, 2023

Current Playwright Test Results Summary

✅ 115 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/03/2023 01:31:31pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 3dd88ee

Started: 08/03/2023 01:29:17pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
0.35% (1) 1 / 283 run
failed over last 7 days
24.03% (68) 68 / 283 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
1.74% (5) 5 / 287 runs
failed over last 7 days
96.17% (276) 276 / 287 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode added automated-tests area: unit tests, e2e tests, playwright High priority Created by Linear-GitHub Sync labels Aug 2, 2023
@keithwillcode keithwillcode requested a review from a team August 2, 2023 10:19
Copy link
Copy Markdown
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use these same settings for the other e2e jobs as well, right?

@nicktrn
Copy link
Copy Markdown
Contributor

nicktrn commented Aug 2, 2023

Just a quick heads up that I plan to open an RFC today re fully parallel e2e email testing. Does not require messing around with mailhog, auth, new env vars, etc. Did some prototyping and think this could work well.

@nicktrn nicktrn mentioned this pull request Aug 2, 2023
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do this in e2e-appstore and embed as well?

@shivamklr
Copy link
Copy Markdown
Contributor Author

@zomars If they use the same endpoints/components then no.

@shivamklr
Copy link
Copy Markdown
Contributor Author

@zomars Just to clear things up. I will be doing this for the core e2e first. Once we cover that, we can move the changes so it covers all the e2e.

@keithwillcode keithwillcode self-requested a review August 3, 2023 16:46
@keithwillcode keithwillcode merged commit 506ef20 into main Aug 3, 2023
@keithwillcode keithwillcode deleted the feat/mailhog-workflow branch August 3, 2023 16:46
@shivamklr shivamklr mentioned this pull request Aug 11, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-tests area: unit tests, e2e tests, playwright core area: core, team members only High priority Created by Linear-GitHub Sync

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants