branch: merge v1.3.0 fix ups from master to develop#1917
Merged
brilliant-lx merged 24 commits intodevelopfrom Oct 13, 2023
Merged
branch: merge v1.3.0 fix ups from master to develop#1917brilliant-lx merged 24 commits intodevelopfrom
brilliant-lx merged 24 commits intodevelopfrom
Conversation
release: draft release v1.2.7
release: draft release v1.2.8
release: draft release v1.2.9
draft release v1.2.10
PR merge will append the PR number at the end, like:... (#1805), which has extra 8 characters
draft release v1.2.11
draft release v1.2.12
draft release v1.3.0
When MatcherSession encounters an error, it attempts to close the session. Closing waits for all goroutines to finish, including the 'distributor'. However, the distributor will not exit until all requests have returned. This patch fixes the issue by delivering the (empty) result to the distributor before calling Close().
* cmd: add tests for init-network command * cmd: add setup function
Co-authored-by: buddh0 <galaxystroller@gmail.com>
buddh0
approved these changes
Oct 13, 2023
galaio
approved these changes
Oct 13, 2023
fynnss
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
v1.3.0 was mainly for big merge, but the current develop branch contains many code for PBSS, which are not included in master branch. So we decided to merge bugfix PRs to master directly, instead of: PR -> Develop -> Master.
As v1.3.0 has been delivered, now we can merge these PRs back to develop.
Rationale
NA
Example
NA
Changes
NA