core/vm: clean up evm clearly when get it from pool#1914
Merged
brilliant-lx merged 1 commit intobnb-chain:masterfrom Oct 11, 2023
Merged
core/vm: clean up evm clearly when get it from pool#1914brilliant-lx merged 1 commit intobnb-chain:masterfrom
brilliant-lx merged 1 commit intobnb-chain:masterfrom
Conversation
zlacfzy
approved these changes
Oct 11, 2023
weiihann
approved these changes
Oct 11, 2023
brilliant-lx
approved these changes
Oct 11, 2023
Contributor
brilliant-lx
left a comment
There was a problem hiding this comment.
LGTM and seems only RPCs call like traceCall will trigger this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/vm: clean up evm clearly when get it from pool
Rationale
before big merge, code is following
miss it when big merge
Example
add an example CLI or API response...
Changes
Notable changes: