core/state: ensure triedb Commit after Update#1900
Merged
brilliant-lx merged 1 commit intobnb-chain:masterfrom Sep 27, 2023
Merged
core/state: ensure triedb Commit after Update#1900brilliant-lx merged 1 commit intobnb-chain:masterfrom
brilliant-lx merged 1 commit intobnb-chain:masterfrom
Conversation
Contributor
|
LGTM |
joey0612
approved these changes
Sep 27, 2023
brilliant-lx
approved these changes
Sep 27, 2023
galaio
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/state: ensure triedb Commit after Update
Rationale
if Commit first, and then Update, trie nodes may not write into disk correctly
and it lead to memory leak in archive mode
Example
add an example CLI or API response...
Changes
Notable changes: