Skip to content

fix: skip HasState check for fast node#1901

Merged
brilliant-lx merged 1 commit intobnb-chain:masterfrom
brilliant-lx:fix_fastnode
Sep 28, 2023
Merged

fix: skip HasState check for fast node#1901
brilliant-lx merged 1 commit intobnb-chain:masterfrom
brilliant-lx:fix_fastnode

Conversation

@brilliant-lx
Copy link
Copy Markdown
Contributor

@brilliant-lx brilliant-lx commented Sep 27, 2023

Description

fast node has no trie, no need to check hasState check.

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@NathanBSC
Copy link
Copy Markdown
Contributor

memo:
bc.HasState is equal to state.New logically,
but here bc.snaps is not assigned, so lead to error

Copy link
Copy Markdown
Contributor

@sunny2022da sunny2022da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brilliant-lx brilliant-lx merged commit 4b45c59 into bnb-chain:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants