core/txpool: ignore nil sub when subpool have been shut down#1915
Merged
buddh0 merged 1 commit intobnb-chain:masterfrom Oct 12, 2023
Merged
core/txpool: ignore nil sub when subpool have been shut down#1915buddh0 merged 1 commit intobnb-chain:masterfrom
buddh0 merged 1 commit intobnb-chain:masterfrom
Conversation
galaio
approved these changes
Oct 11, 2023
brilliant-lx
approved these changes
Oct 11, 2023
zlacfzy
approved these changes
Oct 12, 2023
fynnss
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/txpool: ignore nil sub when subpool have been shut down
Rationale
keep continue subscribing result of txs,
when stop geth, report error as following
It's caused by nil subscription when subpool has been shut down.
Example
add an example CLI or API response...
Changes
Notable changes: