core/state: skip handleDestruction in hash based mode#1908
Merged
brilliant-lx merged 1 commit intobnb-chain:masterfrom Oct 8, 2023
Merged
Conversation
brilliant-lx
approved these changes
Oct 8, 2023
Contributor
brilliant-lx
left a comment
There was a problem hiding this comment.
it is ok for Hash based, but Path based will need to handle it in the future.
fynnss
reviewed
Oct 8, 2023
RenRick
reviewed
Oct 8, 2023
44eed4a to
909f53e
Compare
909f53e to
717f0c4
Compare
RenRick
approved these changes
Oct 8, 2023
joey0612
approved these changes
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/state: skip handleDestruction in hash based mode
Rationale
TestStateChangesfails now, but it is designed for path based only,and is fixed in core/state: implement fast storage deletion (#27955) #1909,
so disable it for now.
Example
add an example CLI or API response...
Changes
Notable changes: