Merged
Conversation
3c358eb to
8c5cee1
Compare
96f5b14 to
345452b
Compare
MatusKysel
reviewed
Sep 28, 2023
MatusKysel
approved these changes
Sep 28, 2023
emailtovamos
approved these changes
Sep 29, 2023
brilliant-lx
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests for the
init-networkcommand.Additionally the command is modified a bit so that the datadir of a new node is configured before the node is created. This ensures that the empty
bsc.logfiles get created in the node's folder instead of the current directory (which requires a manual cleanup step by the user later).Rationale
Only two tests are added not to burden the test suite. The two tests cover the two major scenarios: 1. when the nodes in the cluster are all in the same machine, and 2. when the nodes will run in different IPs.
Example
Changes
Notable changes: