Skip to content

Switch to pirates for babel-register.#3670

Merged
danez merged 7 commits into7.0from
ariporad-pirates
Apr 23, 2017
Merged

Switch to pirates for babel-register.#3670
danez merged 7 commits into7.0from
ariporad-pirates

Conversation

@danez
Copy link
Member

@danez danez commented Aug 22, 2016 •
edited
Loading

This is the follow up for #3139 and #3609

This uses pirates for registering the module extension and adds basic tests

danez/pirates#27

@danez danez changed the title Ariporad pirates Switch to pirates for babel-register. Aug 22, 2016
@codecov-io
Copy link

codecov-io commented Aug 22, 2016 •
edited by codecov bot
Loading

Codecov Report

Merging #3670 into 7.0 will increase coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##             7.0   #3670      +/-   ##
========================================
+ Coverage   85.5%   85.5%   +<.01%     
========================================
  Files         80     200     +120     
  Lines       5706    9495    +3789     
  Branches    1842    2700     +858     
========================================
+ Hits        4879    8119    +3240     
- Misses       557     882     +325     
- Partials     270     494     +224
Impacted Files Coverage Δ
packages/babel-register/src/node.js 83.72% <93.33%> (+0.38%) ⬆️
packages/babel-register/src/cache.js 76.19% <0%> (-6.57%) ⬇️
packages/babel-generator/src/node/whitespace.js 92.18% <0%> (-2.07%) ⬇️
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%) ⬇️
...elper-transform-fixture-test-runner/src/helpers.js 100% <0%> (ø) ⬆️
packages/babel-generator/src/generators/jsx.js 100% <0%> (ø) ⬆️
lib/file.js
lib/types.js
packages/babel-cli/bin/babel-node.js
packages/babel-cli/index.js
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878a7c5...33edc46. Read the comment docs.

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 22, 2016
@danez danez changed the title Switch to pirates for babel-register. [WIP] Switch to pirates for babel-register. Aug 22, 2016
@ariporad
Copy link
Contributor

ariporad commented Aug 24, 2016

@danez: I'm so sorry I haven't had a chance to submit this PR yet! It really was on my todo list, I swear! Regardless, thanks so much anyway!

I commented on your pirates PR. And I'm more than happy to add you to a contributor to pirates as well. (Hopefully life will calm down soon and I'll actually have some time to work on it properly.)

@hzoo hzoo mentioned this pull request Sep 10, 2016
Closed
@danez danez changed the title [WIP] Switch to pirates for babel-register. Switch to pirates for babel-register. Sep 25, 2016
@danez danez added this to the Babel 7 milestone Jan 23, 2017
@loganfsmyth loganfsmyth mentioned this pull request Feb 27, 2017
Closed
@danez danez force-pushed the ariporad-pirates branch from a5b9782 to 19b69eb Compare March 8, 2017 15:14
@danez danez changed the base branch from master to 7.0 March 8, 2017 15:14
hzoo
hzoo approved these changes Mar 8, 2017
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we should look into issues in pkg: register and triage (close, figure out if this fixes it, make a new pr)

@bcoe
Copy link
Contributor

bcoe commented Mar 24, 2017

@danez @ariporad this is awesome; will be cool to try this out with nyc after, I think we had some longstanding issues around babel-register + nyc.

Ari Porad and others added 6 commits April 3, 2017 22:43
@danez
Switch to pirates for babel-register.
2875a2a 
Pirates is a simple module that enables easy require hooking. It makes sure that your require hook works properly. It also makes the implimentation of babel-register a lot simpler.

For more on pirates: http://ariporad.link/piratesjs
@danez
Use modified version of pirates.
bfa2de8
@danez
Switch back to stable version
1ebaa55
@danez
Initial tests for babel-register
9ebfe92
@danez
Fix tests to work in new test env
d2056a1
@danez
Fix for new ignore behaviour
ef0764e
@danez danez force-pushed the ariporad-pirates branch from 19b69eb to ef0764e Compare April 3, 2017 22:15
@danez
Copy link
Member Author

danez commented Apr 7, 2017

Are we okay with merging this now? @hzoo @loganfsmyth

@danez danez merged commit fce92fa into 7.0 Apr 23, 2017
@danez danez deleted the ariporad-pirates branch April 23, 2017 22:25
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
@hulkish
Merge branch 'master' of github.com:hulkish/babel
485c8c7 
* 'master' of github.com:hulkish/babel: (190 commits)
  Fix incorrect property ordering with obj rest spread on nested (babel#5685)
  Fix PathHoister hoisting before a same-scope variable declaration.
  Updated transform-react-display-name for createReactClass addon (babel#5554)
  Fix PathHoister error attaching after export declarations.
  add .mjs to list of well known extensions
  Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676)
  use find-cache-dir for babel-register cache (babel#5669)
  Fix operator processing in object super.
  -> parsedAst
  string -> sourceCode, ast -> generatedCode
  back to babylon
  Switch to pirates for babel-register. (babel#3670)
  [skip ci] babylon -> babel, ast -> parsedAst
  [readme] change code -> string
  Add support for object type spread (babel#5525)
  Fix object destructuring in param arrays (babel#5650)
  Remove merge helper and add more type declarations. (babel#5649)
  Typecheck much more of the config loading process (babel#5642)
  update to alpha.9 (babel#5639)
  v7.0.0-alpha.9
  ...
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
@hulkish
Merge branch '7.0' of https://github.com/babel/babel into 7.0
362443c 
* '7.0' of https://github.com/babel/babel: (190 commits)
  Fix incorrect property ordering with obj rest spread on nested (babel#5685)
  Fix PathHoister hoisting before a same-scope variable declaration.
  Updated transform-react-display-name for createReactClass addon (babel#5554)
  Fix PathHoister error attaching after export declarations.
  add .mjs to list of well known extensions
  Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676)
  use find-cache-dir for babel-register cache (babel#5669)
  Fix operator processing in object super.
  -> parsedAst
  string -> sourceCode, ast -> generatedCode
  back to babylon
  Switch to pirates for babel-register. (babel#3670)
  [skip ci] babylon -> babel, ast -> parsedAst
  [readme] change code -> string
  Add support for object type spread (babel#5525)
  Fix object destructuring in param arrays (babel#5650)
  Remove merge helper and add more type declarations. (babel#5649)
  Typecheck much more of the config loading process (babel#5642)
  update to alpha.9 (babel#5639)
  v7.0.0-alpha.9
  ...
@jridgewell jridgewell mentioned this pull request Sep 14, 2017
Closed
@bensaufley bensaufley mentioned this pull request Apr 6, 2018
Closed
@bensaufley bensaufley mentioned this pull request Apr 20, 2018
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hzoo hzoo hzoo approved these changes

@existentialism existentialism Awaiting requested review from existentialism

@loganfsmyth loganfsmyth Awaiting requested review from loganfsmyth

@DrewML DrewML Awaiting requested review from DrewML

@xtuc xtuc Awaiting requested review from xtuc

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Milestone

Babel 7 Beta

Development

Successfully merging this pull request may close these issues.

5 participants

@danez @codecov-io @ariporad @bcoe @hzoo