Remove merge helper and add more type declarations.#5649
Merged
loganfsmyth merged 1 commit intobabel:7.0from Apr 19, 2017
Merged
Remove merge helper and add more type declarations.#5649loganfsmyth merged 1 commit intobabel:7.0from
loganfsmyth merged 1 commit intobabel:7.0from
Conversation
|
@loganfsmyth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @forivall and @DmitrySoshnikov to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## 7.0 #5649 +/- ##
==========================================
+ Coverage 84.32% 84.39% +0.06%
==========================================
Files 285 284 -1
Lines 9761 9753 -8
Branches 2737 2734 -3
==========================================
Hits 8231 8231
+ Misses 1014 1008 -6
+ Partials 516 514 -2
Continue to review full report at Codecov.
|
xtuc
reviewed
Apr 19, 2017
|
|
||
| declare module "lodash/merge" { | ||
| declare export default <T: Object>(T, Object) => T; | ||
| } |
Member
There was a problem hiding this comment.
Maybe we should use https://github.com/flowtype/flow-typed?
Member
Author
There was a problem hiding this comment.
Yeah, I thought about it, but it only has declarations for the root lodash module, so since we use the lodash/merge and such, it didn't work. If we switch over to the global module we definitely can use flow-typed eventually though.
hulkish
added a commit
to hulkish/babel
that referenced
this pull request
May 2, 2017
* 'master' of github.com:hulkish/babel: (190 commits) Fix incorrect property ordering with obj rest spread on nested (babel#5685) Fix PathHoister hoisting before a same-scope variable declaration. Updated transform-react-display-name for createReactClass addon (babel#5554) Fix PathHoister error attaching after export declarations. add .mjs to list of well known extensions Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676) use find-cache-dir for babel-register cache (babel#5669) Fix operator processing in object super. -> parsedAst string -> sourceCode, ast -> generatedCode back to babylon Switch to pirates for babel-register. (babel#3670) [skip ci] babylon -> babel, ast -> parsedAst [readme] change code -> string Add support for object type spread (babel#5525) Fix object destructuring in param arrays (babel#5650) Remove merge helper and add more type declarations. (babel#5649) Typecheck much more of the config loading process (babel#5642) update to alpha.9 (babel#5639) v7.0.0-alpha.9 ...
hulkish
added a commit
to hulkish/babel
that referenced
this pull request
May 2, 2017
* '7.0' of https://github.com/babel/babel: (190 commits) Fix incorrect property ordering with obj rest spread on nested (babel#5685) Fix PathHoister hoisting before a same-scope variable declaration. Updated transform-react-display-name for createReactClass addon (babel#5554) Fix PathHoister error attaching after export declarations. add .mjs to list of well known extensions Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676) use find-cache-dir for babel-register cache (babel#5669) Fix operator processing in object super. -> parsedAst string -> sourceCode, ast -> generatedCode back to babylon Switch to pirates for babel-register. (babel#3670) [skip ci] babylon -> babel, ast -> parsedAst [readme] change code -> string Add support for object type spread (babel#5525) Fix object destructuring in param arrays (babel#5650) Remove merge helper and add more type declarations. (babel#5649) Typecheck much more of the config loading process (babel#5642) update to alpha.9 (babel#5639) v7.0.0-alpha.9 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more types and removed our
mergeWithhelper because it is no longer needed now that plugin ordering is explicitly handled in option-manager from https://github.com/babel/babel/pull/5602/files#diff-86d518831fa938a96b0f375e1c81d207R111