Conversation
|
@pwmckenna, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @hzoo and @DrewML to be potential reviewers. |
327e956 to
a7eba83
Compare
|
I think you need to rebase, and see if we can add a test for this (it's fine without too), nice work! |
|
@hzoo just rebased. Any ideas on how to test this? Couldn't think of anything lighter weight than mocking out the filesystem (and I haven't done that in node) |
Codecov Report
@@ Coverage Diff @@
## 7.0 #5669 +/- ##
==========================================
+ Coverage 84.39% 84.42% +0.02%
==========================================
Files 284 284
Lines 9749 9750 +1
Branches 2733 2734 +1
==========================================
+ Hits 8228 8231 +3
+ Misses 1009 1006 -3
- Partials 512 513 +1
Continue to review full report at Codecov.
|
|
If nothing in https://github.com/babel/babel/blob/7.0/packages/babel-register/test/cache.js gives any insights we can skip |
|
@hzoo I gave it a quick pass and couldn't figure out a simple way to do it. I'd be up for skipping it, but I can also take another look this weekend when I have more time. |
|
Cool, thanks for this @pwmckenna! Should make clearing cache much easier for everyone |
* 'master' of github.com:hulkish/babel: (190 commits) Fix incorrect property ordering with obj rest spread on nested (babel#5685) Fix PathHoister hoisting before a same-scope variable declaration. Updated transform-react-display-name for createReactClass addon (babel#5554) Fix PathHoister error attaching after export declarations. add .mjs to list of well known extensions Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676) use find-cache-dir for babel-register cache (babel#5669) Fix operator processing in object super. -> parsedAst string -> sourceCode, ast -> generatedCode back to babylon Switch to pirates for babel-register. (babel#3670) [skip ci] babylon -> babel, ast -> parsedAst [readme] change code -> string Add support for object type spread (babel#5525) Fix object destructuring in param arrays (babel#5650) Remove merge helper and add more type declarations. (babel#5649) Typecheck much more of the config loading process (babel#5642) update to alpha.9 (babel#5639) v7.0.0-alpha.9 ...
* '7.0' of https://github.com/babel/babel: (190 commits) Fix incorrect property ordering with obj rest spread on nested (babel#5685) Fix PathHoister hoisting before a same-scope variable declaration. Updated transform-react-display-name for createReactClass addon (babel#5554) Fix PathHoister error attaching after export declarations. add .mjs to list of well known extensions Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676) use find-cache-dir for babel-register cache (babel#5669) Fix operator processing in object super. -> parsedAst string -> sourceCode, ast -> generatedCode back to babylon Switch to pirates for babel-register. (babel#3670) [skip ci] babylon -> babel, ast -> parsedAst [readme] change code -> string Add support for object type spread (babel#5525) Fix object destructuring in param arrays (babel#5650) Remove merge helper and add more type declarations. (babel#5649) Typecheck much more of the config loading process (babel#5642) update to alpha.9 (babel#5639) v7.0.0-alpha.9 ...
|
Glad to see this moved out of $HOME but disappointed to see babel still not conforming to the XDG specification for cache files :( The XDG specification https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html directs cache files to be under |
Make the preferred cache location for babel-register
./node_modules/.cache/babel-registerto match the convention used by babel-loader, ava, etc