Updated transform-react-display-name for createReactClass addon by bvaughn · Pull Request #5554 · babel/babel

bvaughn · 2017-03-27T23:39:46Z

Q	A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	Yes
Deprecations?
Spec Compliancy?
Tests Added/Pass?	Yes
Fixed Tickets
License	MIT
Doc PR
Dependency Changes

The React team will be deprecating React.createClass soon (see facebook/react/pull/9232). This method will be moving to a new add-on package create-react-class (~~not yet released~~ edit Released on Friday, April 7). We are in the process of creating a codemod now that will replace:

import React from 'react';

React.createClass({...})

with:

import createReactClass from 'create-react-class';

createReactClass({...})

This diff updates the transform-react-display-name plugin to handle the new naming convention (createReactClass) as well as the pre-existing use case (React.createClass) in order to remain backwards compatible with existing versions of React. The new check is a naive string comparison and so it's pretty weak- but hopefully this is sufficient given that createClass is deprecated going forward.

Caveat: It is possible that someone will manually write code using the new add-on that does not conform to the naming convention used by the codemod. This use case is not supported.

cc @acdlite

mention-bot · 2017-03-27T23:39:47Z

@bvaughn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @loganfsmyth to be potential reviewers.

hzoo · 2017-03-28T01:13:14Z

@bvaughn yeah the only other relevant issue I remember is #4663 which we never merged

bvaughn · 2017-03-28T01:46:32Z

This PR is a bit more narrow-scope than that issue since it's only concerned with createClass usage. Functions/classes generally have a name attribute that React will already use instead of the displayName so I'm not sure how pressing the other request is. Maybe there are use cases I'm not thinking about (other than IE <= 11)?

hzoo

lgtm! 🙂

hzoo · 2017-03-28T19:38:14Z

packages/babel-plugin-transform-react-display-name/README.md


 ```js
-var foo = React.createClass({});
+var foo = React.createClass({}); // React <= 15


dono if we want to modify > Add displayName to React.createClass calls above this too

We should definitely update the docs after the codemod/package are published

Sure thing fellas. Sorry it took me a bit to circle back here. Got pulled away on some react-native stuff. Wording has been updated.

acdlite · 2017-03-28T21:48:40Z

~~Let's use createReactClass instead~~ Never mind, don't have ownership of the package (yet?). ReactCreateClass is fine.

bvaughn · 2017-03-30T20:41:20Z

Sounds like we have decided to go with createReactClass instead of ReactCreateClass~ so I've made one last update to this transform. Sorry for the churn!

acdlite · 2017-03-30T20:42:14Z

Let's maybe wait to merge this until 15.5 is released, just in case

hzoo · 2017-03-30T20:46:21Z

FYI this will be targeting 7.0 anyway unless you also do a backport to 6.x

hzoo · 2017-03-30T20:47:40Z

Also adding both of you to a "react" team on babel (just read access atm) so that we can assign people if that's cool (who else should I add). doing the same for flow

going to use the area: react label

acdlite · 2017-03-30T20:51:07Z

Dan is already added I think. The rest of the team is sebmarkbage, spicyj, trueadm, and flarnie.

hzoo · 2017-03-30T20:57:34Z

the flow I was thinking of

issues: in an updated version of the issue template maybe can specify a place for a user to auto label an issue.
pr: the babel-bot can read if the files touch affect packages/babel-plugin-*-react-* and then @ mention the relevant team. Or just modify mention-bot to do it (easier).

timdorr · 2017-04-10T14:27:38Z

/poke

Looks like I borked a release on react-router 3.x, since we use createClass in that version. Would love to get this out and backported to 6.x. Let me know if I can help!

immortal-tofu · 2017-04-13T12:46:59Z

LGTM

hzoo · 2017-05-01T21:11:41Z

@timdorr yeah feel free to do the backport pr

* 'master' of github.com:hulkish/babel: (190 commits) Fix incorrect property ordering with obj rest spread on nested (babel#5685) Fix PathHoister hoisting before a same-scope variable declaration. Updated transform-react-display-name for createReactClass addon (babel#5554) Fix PathHoister error attaching after export declarations. add .mjs to list of well known extensions Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676) use find-cache-dir for babel-register cache (babel#5669) Fix operator processing in object super. -> parsedAst string -> sourceCode, ast -> generatedCode back to babylon Switch to pirates for babel-register. (babel#3670) [skip ci] babylon -> babel, ast -> parsedAst [readme] change code -> string Add support for object type spread (babel#5525) Fix object destructuring in param arrays (babel#5650) Remove merge helper and add more type declarations. (babel#5649) Typecheck much more of the config loading process (babel#5642) update to alpha.9 (babel#5639) v7.0.0-alpha.9 ...

* '7.0' of https://github.com/babel/babel: (190 commits) Fix incorrect property ordering with obj rest spread on nested (babel#5685) Fix PathHoister hoisting before a same-scope variable declaration. Updated transform-react-display-name for createReactClass addon (babel#5554) Fix PathHoister error attaching after export declarations. add .mjs to list of well known extensions Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676) use find-cache-dir for babel-register cache (babel#5669) Fix operator processing in object super. -> parsedAst string -> sourceCode, ast -> generatedCode back to babylon Switch to pirates for babel-register. (babel#3670) [skip ci] babylon -> babel, ast -> parsedAst [readme] change code -> string Add support for object type spread (babel#5525) Fix object destructuring in param arrays (babel#5650) Remove merge helper and add more type declarations. (babel#5649) Typecheck much more of the config loading process (babel#5642) update to alpha.9 (babel#5639) v7.0.0-alpha.9 ...

itkach · 2017-05-05T21:55:16Z

Any chance to have this backported to babel 6?

bvaughn · 2017-05-05T22:12:55Z

@timdorr: Looks like I borked a release on react-router 3.x, since we use createClass in that version. Would love to get this out and backported to 6.x. Let me know if I can help!

@hzoo: @timdorr yeah feel free to do the backport pr

@itkach Seems like someone would just need to submit a PR

…l#5554) * Updated transform-react-display-name for ReactCreateClass addon * Tweaked description for transform-react-display-name plugin * Changed ReactCreateClass to createReactClass

Updated transform-react-display-name for ReactCreateClass addon

17fe2ef

bvaughn mentioned this pull request Mar 27, 2017

Remove createClass facebook/react#9232

Merged

existentialism added area: react PR: New Feature 🚀 A type of pull request used for our changelog categories labels Mar 27, 2017

hzoo approved these changes Mar 28, 2017

View reviewed changes

hzoo reviewed Mar 28, 2017

View reviewed changes

acdlite mentioned this pull request Mar 28, 2017

Update class transform to fallback to react-create-class package reactjs/react-codemod#101

Merged

Tweaked description for transform-react-display-name plugin

58c41ac

existentialism approved these changes Mar 29, 2017

View reviewed changes

Changed ReactCreateClass to createReactClass

463d995

bvaughn force-pushed the react-create-class-addon branch from ac8a31a to 463d995 Compare March 30, 2017 20:40

bvaughn changed the title ~~Updated transform-react-display-name for ReactCreateClass addon~~ Updated transform-react-display-name for createReactClass addon Mar 30, 2017

timdorr mentioned this pull request Apr 10, 2017

react-router 3.0.4 own react elements become <Unknown/> remix-run/react-router#4947

Closed

bvaughn mentioned this pull request Apr 10, 2017

15.5 addon bugs facebook/react#9384

Closed

10 tasks

stevemao referenced this pull request in akiran/react-slick Apr 18, 2017

Removed usage of responsive mixin

b798b1f

This was referenced Apr 18, 2017

Set a displayName for the component nkbt/react-collapse#160

Closed

After update to 0.4.8 shapshot testing fails chenglou/react-motion#454

Open

hzoo merged commit 526a7d2 into babel:7.0 May 1, 2017

bvaughn deleted the react-create-class-addon branch May 5, 2017 22:11

itkach mentioned this pull request May 6, 2017

Updated transform-react-display-name for createReactClass addon #5711

Closed

kentor mentioned this pull request May 26, 2017

Backport support for createReactClass with transform-react-display-name #5780

Merged

snyk-bot mentioned this pull request Aug 30, 2019

[Snyk] Upgrade babel-runtime from 6.18.0 to 6.26.0 aarlaud/two-factor-loginattempt-issue-MCV#1

Open

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019

Uh oh!

Conversation

bvaughn commented Mar 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Mar 27, 2017

Uh oh!

hzoo commented Mar 28, 2017

Uh oh!

bvaughn commented Mar 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hzoo left a comment

Choose a reason for hiding this comment

Uh oh!

hzoo Mar 28, 2017

Choose a reason for hiding this comment

Uh oh!

existentialism Mar 28, 2017

Choose a reason for hiding this comment

Uh oh!

bvaughn Mar 29, 2017

Choose a reason for hiding this comment

Uh oh!

acdlite commented Mar 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bvaughn commented Mar 30, 2017

Uh oh!

acdlite commented Mar 30, 2017

Uh oh!

hzoo commented Mar 30, 2017

Uh oh!

hzoo commented Mar 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acdlite commented Mar 30, 2017

Uh oh!

hzoo commented Mar 30, 2017

Uh oh!

timdorr commented Apr 10, 2017

Uh oh!

immortal-tofu commented Apr 13, 2017

Uh oh!

hzoo commented May 1, 2017

Uh oh!

itkach commented May 5, 2017

Uh oh!

bvaughn commented May 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bvaughn commented Mar 27, 2017 •

edited

Loading

bvaughn commented Mar 28, 2017 •

edited

Loading

acdlite commented Mar 28, 2017 •

edited

Loading

hzoo commented Mar 30, 2017 •

edited

Loading