Skip to content

Fix incorrect property ordering with obj rest spread on nested#5685

Merged
hzoo merged 1 commit into7.0from
issue5629
May 2, 2017
Merged

Fix incorrect property ordering with obj rest spread on nested#5685
hzoo merged 1 commit into7.0from
issue5629

Conversation

@existentialism
Copy link
Member

@existentialism existentialism commented May 1, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? yes/yes
Fixed Tickets Fixes #5629
License MIT
Doc PR
Dependency Changes

@existentialism existentialism added pkg: object-rest-spread PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels May 1, 2017
@mention-bot
Copy link

mention-bot commented May 1, 2017

@existentialism, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @erikdesjardins and @loganfsmyth to be potential reviewers.

@codecov
Copy link

codecov bot commented May 1, 2017 •
edited
Loading

Codecov Report

Merging #5685 into 7.0 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5685      +/-   ##
==========================================
+ Coverage   84.55%   84.58%   +0.02%     
==========================================
  Files         283      283              
  Lines        9733     9735       +2     
  Branches     2732     2732              
==========================================
+ Hits         8230     8234       +4     
+ Misses        990      988       -2     
  Partials      513      513
Impacted Files Coverage Δ
...l-plugin-transform-object-rest-spread/src/index.js 98.37% <100%> (+0.05%) ⬆️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
packages/babel-traverse/src/path/lib/hoister.js 90.9% <0%> (-0.19%) ⬇️
packages/babel-traverse/src/path/context.js 85.34% <0%> (ø) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.42%) ⬆️
packages/babel-traverse/src/path/modification.js 74.75% <0%> (+0.97%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e8cc8...da5e355. Read the comment docs.

hzoo
hzoo approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a test for another level of nesting?

@hzoo hzoo requested a review from loganfsmyth May 1, 2017 21:53
@hzoo hzoo merged commit 79c1eed into 7.0 May 2, 2017
@existentialism existentialism deleted the issue5629 branch May 2, 2017 18:05
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
@hulkish
Merge branch 'master' of github.com:hulkish/babel
485c8c7 
* 'master' of github.com:hulkish/babel: (190 commits)
  Fix incorrect property ordering with obj rest spread on nested (babel#5685)
  Fix PathHoister hoisting before a same-scope variable declaration.
  Updated transform-react-display-name for createReactClass addon (babel#5554)
  Fix PathHoister error attaching after export declarations.
  add .mjs to list of well known extensions
  Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676)
  use find-cache-dir for babel-register cache (babel#5669)
  Fix operator processing in object super.
  -> parsedAst
  string -> sourceCode, ast -> generatedCode
  back to babylon
  Switch to pirates for babel-register. (babel#3670)
  [skip ci] babylon -> babel, ast -> parsedAst
  [readme] change code -> string
  Add support for object type spread (babel#5525)
  Fix object destructuring in param arrays (babel#5650)
  Remove merge helper and add more type declarations. (babel#5649)
  Typecheck much more of the config loading process (babel#5642)
  update to alpha.9 (babel#5639)
  v7.0.0-alpha.9
  ...
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
@hulkish
Merge branch '7.0' of https://github.com/babel/babel into 7.0
362443c 
* '7.0' of https://github.com/babel/babel: (190 commits)
  Fix incorrect property ordering with obj rest spread on nested (babel#5685)
  Fix PathHoister hoisting before a same-scope variable declaration.
  Updated transform-react-display-name for createReactClass addon (babel#5554)
  Fix PathHoister error attaching after export declarations.
  add .mjs to list of well known extensions
  Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676)
  use find-cache-dir for babel-register cache (babel#5669)
  Fix operator processing in object super.
  -> parsedAst
  string -> sourceCode, ast -> generatedCode
  back to babylon
  Switch to pirates for babel-register. (babel#3670)
  [skip ci] babylon -> babel, ast -> parsedAst
  [readme] change code -> string
  Add support for object type spread (babel#5525)
  Fix object destructuring in param arrays (babel#5650)
  Remove merge helper and add more type declarations. (babel#5649)
  Typecheck much more of the config loading process (babel#5642)
  update to alpha.9 (babel#5639)
  v7.0.0-alpha.9
  ...
@existentialism existentialism mentioned this pull request May 19, 2017
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hzoo hzoo hzoo approved these changes

@loganfsmyth loganfsmyth Awaiting requested review from loganfsmyth

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Object Rest/Spread

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@existentialism @mention-bot @hzoo