Conversation
Pirates is a simple module that enables easy require hooking. It makes sure that your require hook works properly. It also makes the implimentation of babel-register a lot simpler. For more on pirates: http://ariporad.link/piratesjs
|
What is going on with the tests.. /home/travis/build/babel/babel/packages/babel-generator/node_modules/babylon/node_modules/babel-runtime/helpers/typeof.js:19 |
|
I think one issue is that pirates is not really reverting, before being called twice. which we currently do. And it is replacing module._compile but never reverting it. |
|
@hzoo: Hmm... I have no idea why we're getting a |
|
Ah understandable, thats is fine too. |
|
Ok let us know - closing |
|
@ariporad what are your thoughts on deprecating pirates? It seems it would still be useful (eg for stacking babel and ts-node) |
|
@graingert: My primary thoughts are this:
So, TL;DR: I don't really have a whole lot of time to allocate to it atm. If someone else needs it, I'm happy to try and find some time to work on it. I'm also happy to add someone as a contributor. |
|
@hzoo Would you consider applying this update without |
Copied from #3139 but fixed merge conflicts @ariporad
Pirates is a simple module that enables easy require hooking. It makes sure that your require hook works properly. It also makes the implimentation of babel-register a lot simpler.
For more on pirates: http://ariporad.link/piratesjs
This change is completely transparent (a patch version bump), and all the tests still pass.
Fixes #3062.