InnerBlocks: move wrapper classes to BlockList#19849
Closed
InnerBlocks: move wrapper classes to BlockList#19849
Conversation
Member
Are you referring to #18416? |
Contributor
This is likely a feature that is there to enable some blocks where the parent toolbar absorbs the child block toolbar, which makes sense for child blocks that can be rotated, and other situations. It was created in part for 3rd party blocks, so I'd be careful in removing it. CC: @getdave — is this correct? Should we add a note in the code so it's not refactored away? |
This was referenced Jan 27, 2020
New rules were introduced for Prettier validation.
* block-editor: add getBLockParentsByBlockName() * docs: generate selectors doc * navigation: get the proper parent block
* Framework: Add URL polyfill * URL: Conform to URL Living Standard definition of valid URL * Block Editor: Remove redundant checks for `isMailto`, `isTel` These are now considered valid by `isURL` and are not necessary to evaluate separately. * Compat: Register URL polyfill only if not registered * Compat: Add "Remove by" message for URL polyfill * Compat: Add upstream patch ticket reference for URL polyfill
…ask names. (#20034) * Project Management Automation: Log skipped tasks and retain wrapped task names. * Project Management Automation: Set function name properly.
This change updates the margins of the notice UI added to block placeholders using the `withNotices` mixin. The update was necessary after #18745 which made the content of block placeholders left-aligned.
Fix Broken Link in [Glossary Page](https://developer.wordpress.org/block-editor/principles/glossary/)
* Upgrade react native to 0.62.0-rc.1 * Fix focus on plain text for RN It looks there was a type and we were checking the incorrect props. * Revert change on package.json Co-authored-by: Marko Savic <savicmarko1985@gmail.com>
To allow disabling the block popover (which includes the block toolbar and inserter).
#20058) * Project Management Automation: Support adding milestones for fork PRs. * Github: Remove unused workflow event. * Update packages/project-management-automation/lib/add-milestone.js Co-Authored-By: Andrew Duthie <andrew@andrewduthie.com> * Project Management Automation: Update tests. * Project Management Automation: Remove `ifNotFork` from milestone handler. Co-authored-by: Andrew Duthie <andrew@andrewduthie.com>
|
Size Change: +36 kB (4%) Total Size: 866 kB
ℹ️ View Unchanged
|
Contributor
|
Seems like something is off in this PR? (see commits) |
Member
Author
|
Yeah, I think a bad rebase. I added it to #19910. |
ellatrix
added a commit
that referenced
this pull request
Mar 2, 2020
* Lighter InnerBlocks: allow blocks to render own wrappers * Remove getEditWrapperProps * Fix width * Pass all props to block list * Restore max-width rule * Properly forward refs * Incorporate #19849 * Fix alignment styles * Fix writing flow * Nest props that are passed to block component * Merge class names * Fix horizontal margins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the class
is-overlaycurrently added to inner blocks wrapper to the block list wrapper. This will make it easier to allow a block to have its own inner blocks wrapper as all necessary props are already on the same wrapper.It's unfortunate that this wrapper div was added in the past as it seems unnecessary. Quite a few blocks now have selectors for it, so it avoid breakage, it's better to make removing opt-in together with the block list wrapper.
The
is-capturing-toolbaris currently not used by anything.The columns blocks renders a bit strange for small screens, but that's the case in
masteras well.How has this been tested?
Test the click overlays for nested blocks.
Screenshots
Types of changes
Checklist: