Fix: Navigation block: Make function names specific#20039
Merged
jorgefilipecosta merged 1 commit intomasterfrom Feb 5, 2020
Merged
Fix: Navigation block: Make function names specific#20039jorgefilipecosta merged 1 commit intomasterfrom
jorgefilipecosta merged 1 commit intomasterfrom
Conversation
Member
Author
|
@TimothyBJacobs do you think the new function names are adequate? Thank you in advance for any feedback you could provide. |
Member
|
Those names make sense to me! |
retrofox
approved these changes
Feb 4, 2020
Contributor
retrofox
left a comment
There was a problem hiding this comment.
Tested the whole implementation of the <Navigation /> and it works as expected. 👍
Member
|
Related previous effort (and discussion): #18589 |
This was referenced Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The navigation block is defining functions whose name looks generic like build_css_colors.
This PR updates the names of functions in the navigation block to make them specific to the block.
In response to the comment raised by @TimothyBJacobs in trac ticket https://core.trac.wordpress.org/ticket/49348#comment:6. Thank you for catching this issue.
How has this been tested?
I verified the navigation block still works as before.