Move the ellipsis and close icons to the icons library#19959
Move the ellipsis and close icons to the icons library#19959youknowriad merged 4 commits intomasterfrom
Conversation
| type="reset" | ||
| label={ __( 'Reset' ) } | ||
| icon="no-alt" | ||
| icon={ close } |
|
I recall back when we introduced the Ellipsis menu, I was frowned upon for calling it an "overflow menu". Which it technically is — menu items overflow into that menu. But we ended up with some agreement that the menu could be called, the "More menu". Incidentally, there's Material precedence for calling it that:
But we'll need some direction too, as we will likely have both a horizontal more icon, and a vertical more icon. Whether we call the two icons |
|
I like more-horizontal. Noting that today we rotate the icon in CSS and I believe we only use more-vertical in our UI. So should we change the SVG instead as well and name it more-vertical? |
|
We will eventually want BOTH a vertical and a horizontal icon, and not use the SVG rotation (because we might want to use those for effects instead of foundational stuff). So probably call the icon |
428d598 to
e03bdff
Compare
2843434 to
1db82f9
Compare
This PR moves two of the most used dashicons to the icons package: