Fix alignment of notice lists in block placeholders#20024
Merged
epiqueras merged 1 commit intoWordPress:masterfrom Feb 5, 2020
p-jackson:fix/placeholder-notice-padding
Merged
Fix alignment of notice lists in block placeholders#20024epiqueras merged 1 commit intoWordPress:masterfrom p-jackson:fix/placeholder-notice-padding
epiqueras merged 1 commit intoWordPress:masterfrom
p-jackson:fix/placeholder-notice-padding
Conversation
This change updates the margins of the notice UI added to block placeholders using the `withNotices` mixin. The update was necessary after #18745 which made the content of block placeholders left-aligned.
6 tasks
epiqueras
requested changes
Feb 4, 2020
Contributor
epiqueras
left a comment
There was a problem hiding this comment.
I don't think we should remove the set width.
Member
Author
|
Thanks for taking a look at this @epiqueras :)
To my eye at least the full width notice looks a little nicer than having the extra
It's so close to full width that IMO it really feels like it should be anchored to the right-hand side. I'm happy to add the width rule back if that's the layout we want though. I may have missed something that makes the extra space necessary. |
Contributor
|
@jasmussen Did you add the width there for a reason? |
Contributor
|
I'm sure there was a reason, but that reason isn't there anymore. It seems like both of the margin and width rules can be removed:
|
epiqueras
approved these changes
Feb 5, 2020
epiqueras
pushed a commit
that referenced
this pull request
Feb 5, 2020
This change updates the margins of the notice UI added to block placeholders using the `withNotices` mixin. The update was necessary after #18745 which made the content of block placeholders left-aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates the margins of the notice UI added to block placeholders using the
withNoticesmixin. The update was necessary after #18745 which made the content of block placeholders left-aligned.Fixes #19671
How has this been tested?
Screenshots
Before #18745
Block placeholder content is centred.
After #18745
With alignment bug as reported by #19671
After this fix
Vertical margins the same as before #18745, but notice is now full width
Types of changes
Bug fix
Checklist: