Automatically render category keyboard shortcuts#19965
Merged
youknowriad merged 3 commits intomasterfrom Feb 5, 2020
Merged
Conversation
Member
|
Great one. It was a lot of work to get to this stage but it is so neat how much control site owners and plugin authors get 👍 |
d6166c4 to
de1b24c
Compare
de1b24c to
16e4a94
Compare
3d11447 to
002ddb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15205
In This PR, instead of listing the shortcuts to be shown in each category of the help modal, I'm update the code to automatically show the registered shortcuts of that category.
The good news is that this allows third-party plugins to register their shortcuts and they'll show up magically on that help modal. The only requirement is to choose one of these categories (block, selection, global).
Down the road, we can probably open to random categories but this is a good start I think.
The downside of this PR is that we don't control the order of the shortcuts. We could add an alphabetical order or a priority property per shortcut. But we can iterate on that.
Testing instructions