Update of Dilithium and Kyber aarch64#527
Conversation
We probably should extract this... |
|
Please tell me how to proceed since there will be a new update for the code base because of https://mail.google.com/mail/u/0/?tab=rm&ogbl#inbox/FMfcgzGwJJWvxLVmcxTTHGgNnPqFsqzp. |
|
Hi, it'd be nice if you could add the addition of the |
|
I have tried to fix the tests (at least for other schemes) by moving the |
|
| void KeccakF1600_StatePermutex2(v128 state[25]) { | ||
| #if (__APPLE__ && __ARM_FEATURE_CRYPTO) || (__ARM_FEATURE_SHA3) /* although not sure what is being implemented, we find something fast */ | ||
| PQCLEAN_KYBER512_AARCH64_f1600x2(state, neon_KeccakF_RoundConstants); | ||
| f1600x2(state, neon_KeccakF_RoundConstants); |
There was a problem hiding this comment.
Where is f1600x2 supposed to come from? This fails to compile on my M2 Mac.
|
This PR should also be checked if we need to include #533 |
|
Sorry, I accidentally merged this PR 🤦🏼 Could you recreate it? |
|
I re-created it, you should be able to continue pushing to your fork. |
Refs: PQClean/PQClean#504 Refs: PQClean/PQClean#512 Refs: PQClean/PQClean#519 Refs: PQClean/PQClean#521 Refs: PQClean/PQClean#527 Refs: PQClean/PQClean#534 Refs: PQClean/PQClean#535 Refs: PQClean/PQClean#536 Refs: PQClean/PQClean#540 Refs: PQClean/PQClean#541 Refs: PQClean/PQClean#542 Refs: PQClean/PQClean#543
Refs: PQClean/PQClean#504 Refs: PQClean/PQClean#512 Refs: PQClean/PQClean#519 Refs: PQClean/PQClean#521 Refs: PQClean/PQClean#527 Refs: PQClean/PQClean#534 Refs: PQClean/PQClean#535 Refs: PQClean/PQClean#536 Refs: PQClean/PQClean#540 Refs: PQClean/PQClean#541 Refs: PQClean/PQClean#542 Refs: PQClean/PQClean#543
Dear all,
This pull request is an update of the aarch64 implementation of Dilithium and Kyber. Below are the summary of the changes.
(i) An improved version of NTT/iNTT exploiting the parallelism of arithmetic and memory ports (the idea was already applied to other simpler functions)
(ii)
br lr->ret, this resolves open-quantum-safe/liboqs#1448.(iii) Constant declaration at proper .c files and remove unused constants (this resolves #516).
(iv) Clarify the LICENSE file, this resolves #498.
(v) Correct and extend the namespacing, the correction resolves #495.
Related issues that remain: #515.
I need to look into this in the future.
Additionally, I have a question for PQClean: Can I assume that there will be something like fips202x2 for parallelized shake and sha3 on Armv8-A and skip the namespacing for this part?
Currently, I skipped the namespacing for parallelized shake and sha3 since I assumed this.
Thanks,
Vincent